[Symphony]: Symphony logic final (final) version - #3433
Open
lvachon1 wants to merge 1 commit into
Open
Conversation
…e symphony work. Updated alerts_test tests to suit the new logic. There will likely be more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🐬 Symphony logic final (final) version
Implementation
Changed the business logic for stale? alerts, now they're only for the symphony work. Updated alerts_test tests to suit the new logic.
Screenshots
Symphony alert hidden on Subway Status
Symphony alert hidden on Green-E line
Symphony alert shown in Green-E alerts
Symphony alert hidden in Green line
Symphony alert shown in Green alerts
How to test
http://localhost:4001/ & http://localhost:4001/alerts/subway - Confirm the symphony alert isn't shown in Subway Status
http://localhost:4001/schedules/Green-E/line & http://localhost:4001/schedules/Green/line - Confirm the alert doesn't show on the line diagram but does on the Alerts tab
Depending on the order in which these PRs are merged you may want to test the departures page as well.
http://localhost:4001/departures?route_id=Green&direction_id=1&stop_id=place-symcl - Confirm the alert shows
http://localhost:4001/departures?route_id=Green&direction_id=1&stop_id=place-hymnl - Confirm the alert doesn't show