Skip to content

fix: Alignment bug in new timetable - #3431

Merged
joshlarson merged 3 commits into
mainfrom
jdl/fix/new-timetable-alignment-bug
Aug 20, 2026
Merged

fix: Alignment bug in new timetable#3431
joshlarson merged 3 commits into
mainfrom
jdl/fix/new-timetable-alignment-bug

Conversation

@joshlarson

Copy link
Copy Markdown
Contributor

Scope

No ticket, but I just noticed that at certain browser widths (at a guess... even number of pixels? 1000px for instance), if you drag the new timetable scroll bar almost but not quite to the "Latest trips" end of the screen and then click Later <Vehicles>, it goes one pixel too far, and nudges the header with the Earlier/Later buttons out of alignment.

Implementation

  • Prevent the buttons from nudging the scroll bar any further than the actual max scroll.

Screenshots

Screenshot 2026-08-18 at 6 52 28 PM

How to test

Navigate to the Harbor Loop Ferry Timetable page with a browser width of 1000px - on main, you should see the top bar get nudged a little - on this branch, you should see it stay put.

Try other routes and other browser widths!

@joshlarson
joshlarson requested a review from a team as a code owner August 18, 2026 23:14
@joshlarson
joshlarson requested a review from jlucytan August 18, 2026 23:14
@joshlarson

Copy link
Copy Markdown
Contributor Author

This doesn't fully solve the issue - it's still possible to get the misalignment by resizing the browser window and positioning the scroll bar in a specific place.

But this at least solves the problem for the vast majority of cases that someone is likely to actually do 😅

@joshlarson
joshlarson enabled auto-merge (squash) August 18, 2026 23:23
Comment thread assets/ts/phoenix-hooks/timetable-scroll.ts Outdated
@joshlarson
joshlarson merged commit 1f10c26 into main Aug 20, 2026
20 checks passed
@joshlarson
joshlarson deleted the jdl/fix/new-timetable-alignment-bug branch August 20, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants