[ferry] [fare]: Charlestown and Winthrop/Quincy fares changes#3272
Open
lvachon1 wants to merge 6 commits into
Open
[ferry] [fare]: Charlestown and Winthrop/Quincy fares changes#3272lvachon1 wants to merge 6 commits into
lvachon1 wants to merge 6 commits into
Conversation
…c to detect long-way-around trips
Contributor
Author
|
Things seem to work, but the ferry test is failing on trip legs we don't offer. I'll have to look into either the fares logic or the test logic to make things cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: ⛴️ 💸 Charlestown and Winthrop/Quincy fares changes
Implementation
Updated the Charlestown Ferry price
Updated the Winthrop/Quincy logic to detect long-way-around trips
Screenshots
Charlestown Ferry New Price
Winthrop/Quincy Ferry long-way-around via Winthrop
Winthrop/Quincy Ferry long-way-around via Quincy
Winthrop/Quincy Ferry Fan Pier to Logan
Winthrop/Quincy Ferry Fan Pier to Logan via Central Wharf
TODO:
What's with this?

It looks fine in the details of that trip, but looks like a bus in the summary.
How to test
http://localhost:4001/trip-planner