Remove outdated "precision" package keywords#1711
Merged
Merged
Conversation
These keywords referenced a retired product name. The generic "geoip" and "geoip2" keywords remain. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
MaxMind no longer ships the legacy products, so refer to the products as 'GeoIP' and 'GeoLite' rather than 'GeoIP2'/'GeoLite2' in prose. Technical identifiers (package name, types, filenames, edition IDs, hostnames, URLs) are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a mise.toml/mise.lock pinning the language toolchain so local development and validation match CI, consistent with our other client libraries. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
horgh
requested changes
May 29, 2026
Contributor
horgh
left a comment
horgh
left a comment
There was a problem hiding this comment.
From Claude, seems right:
- Missed rename — src/models/Isp.ts:27: still says "The GeoIP2-ISP response". All sibling model files were updated; this one was skipped.
Use the generic 'The GeoIP response' wording used by the other model files. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
horgh
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
geoip precisionandgeoip2 precisionpackage.jsonkeywords, which referenced a retired product name. The genericgeoipandgeoip2keywords remain.🤖 Generated with Claude Code