V11.9 Docs#9043
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the documentation build configuration to reflect the v11.9 documentation version in the Sphinx config, aligning the repo metadata with the intended release.
Changes:
- Updated the commented
versionvalue from11.8to11.9. - Updated the commented
releasevalue from11.8to11.9.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCommented version and release values in ChangesDocumentation Version Bump
ABAC Attribute Value Masking Documentation
Calls Plugin DM Video Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@source/conf.py`:
- Line 529: The version and release configuration variables are currently
commented out, which prevents Sphinx from applying the version bump to '11.9'.
This breaks the sitemap extension's dependency on app.builder.config.version for
generating version-aware URLs. Uncomment both the version and release variable
assignments (currently prefixed with #) to activate the version configuration so
Sphinx will properly use the specified version value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Newest code from mattermost has been published to preview environment for Git SHA 95a735e |
|
Newest code from mattermost has been published to preview environment for Git SHA 4adbaf8 |
|
Newest code from mattermost has been published to preview environment for Git SHA 02f6e2b |
|
Newest code from mattermost has been published to preview environment for Git SHA 3ced511 |
* MM-68992 - add attribute value masking documentation * add details about access mode
There was a problem hiding this comment.
🧹 Nitpick comments (1)
source/administration-guide/manage/admin/abac-system-wide-policies.rst (1)
133-152: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winElevate feature flag requirement to an explicit admonition for consistency and clarity.
The AttributeValueMasking feature flag requirement is stated inline at line 152, whereas the PermissionPolicies feature flag requirement (line 80) is documented in a dedicated
.. note::admonition. Since both are prerequisites that materially affect whether the feature functions, and the masking feature controls visibility of sensitive attribute values, this requirement should receive the same prominent treatment.Proposed structure: Replace line 152 with an `.. important::` admonition
**To edit a masked rule**, ask the policy owner or another System Admin who holds the relevant attribute values to make the change. -This behavior applies to both the table editor and the CEL editor, and also to Team Admin and Channel Admin policy editors in Team Settings and Channel Settings. Requires Enterprise Advanced license and the ``AttributeValueMasking`` feature flag. +This behavior applies to both the table editor and the CEL editor, and also to Team Admin and Channel Admin policy editors in Team Settings and Channel Settings. + +.. important:: + + Attribute value masking requires a Mattermost Enterprise Advanced license and the ``AttributeValueMasking`` feature flag to be enabled. See the Mattermost developer documentation for details on `enabling feature flags in a self-hosted deployment <https://developers.mattermost.com/contribute/more-info/server/feature-flags/#self-hosted-and-local-development>`_. Mattermost Cloud customers can request this feature flag be enabled by contacting their Mattermost Account Manager or by `creating a support ticket <https://support.mattermost.com/hc/en-us/requests/new?ticket_form_id=11184911962004>`_.This approach:
- Matches the style and link pattern already established in the file (lines 80–82)
- Ensures admins understand both prerequisites before deploying this security feature
- Elevates feature flag visibility to match the importance of the security feature it gates
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@source/administration-guide/manage/admin/abac-system-wide-policies.rst` around lines 133 - 152, The AttributeValueMasking feature flag requirement is currently stated inline at the end of the "Attribute value masking" section, whereas the PermissionPolicies feature flag requirement uses a dedicated note admonition for consistency. Replace the inline feature flag text at line 152 with a dedicated `.. important::` admonition that matches the style and link pattern of the existing note block (lines 80-82), ensuring both prerequisites receive equal prominence and that admins understand the feature flag requirement is a prerequisite for the masking feature to function.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@source/administration-guide/manage/admin/abac-system-wide-policies.rst`:
- Around line 133-152: The AttributeValueMasking feature flag requirement is
currently stated inline at the end of the "Attribute value masking" section,
whereas the PermissionPolicies feature flag requirement uses a dedicated note
admonition for consistency. Replace the inline feature flag text at line 152
with a dedicated `.. important::` admonition that matches the style and link
pattern of the existing note block (lines 80-82), ensuring both prerequisites
receive equal prominence and that admins understand the feature flag requirement
is a prerequisite for the masking feature to function.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 57ca31c7-a398-48e6-a6b3-aff4670624b3
📒 Files selected for processing (3)
source/administration-guide/manage/admin/abac-channel-access-rules.rstsource/administration-guide/manage/admin/abac-system-wide-policies.rstsource/administration-guide/manage/admin/user-attributes.rst
✅ Files skipped from review due to trivial changes (1)
- source/administration-guide/manage/admin/abac-channel-access-rules.rst
|
Newest code from mattermost has been published to preview environment for Git SHA 094da26 |
* Document experimental video calls in DMs (Calls v1.12.0) * Note external RTCD v1.2.2+ requirement for DM video calls
|
Newest code from mattermost has been published to preview environment for Git SHA c31cca0 |
|
Newest code from mattermost has been published to preview environment for Git SHA 0ee7d27 |
No description provided.