Skip to content

Add docs for experimental mobile watermarking (v11.7)#8954

Open
Combs7th wants to merge 10 commits into
masterfrom
claude/issue-8953-20260512-0010
Open

Add docs for experimental mobile watermarking (v11.7)#8954
Combs7th wants to merge 10 commits into
masterfrom
claude/issue-8953-20260512-0010

Conversation

@Combs7th

Copy link
Copy Markdown
Contributor

Documents the new Enterprise, experimental “Enable Mobile Watermark” setting introduced by mattermost/mattermost#36025 and the visible mobile watermark overlay introduced by mattermost/mattermost-mobile#9682.

Pages edited

  • source/administration-guide/configure/experimental-configuration-settings.rst — new “Enable Mobile Watermark” entry (Experimental > Features, disabled by default, Enterprise-only, v11.7 onward).
  • source/deployment-guide/mobile/mobile-security-features.rst — deep-dive “Mobile watermarking” section describing the username/domain/date/time overlay and its DLP-attribution purpose.
  • source/security-guide/mobile-security.rst — short overview section linking to the deep-dive and to the experimental config setting.

Closes #8953.

Generated with Claude Code

Documents the new Enterprise, experimental "Enable Mobile Watermark"
setting introduced by mattermost/mattermost#36025 and the visible
mobile watermark overlay introduced by mattermost/mattermost-mobile#9682:

- experimental-configuration-settings.rst: new "Enable Mobile Watermark"
  entry (Experimental > Features, disabled by default, Enterprise-only,
  v11.7 onward).
- deployment-guide/mobile/mobile-security-features.rst: deep-dive
  "Mobile watermarking" section describing the username/domain/date/time
  overlay and its DLP-attribution purpose.
- security-guide/mobile-security.rst: short overview section linking
  to the deep-dive and to the experimental config setting.

Refs issue #8953.

Co-authored-by: Combs7th <Combs7th@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@Combs7th, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21b65f8b-84d3-45f4-a416-9c71fe13119c

📥 Commits

Reviewing files that changed from the base of the PR and between 87040f2 and 79892ac.

📒 Files selected for processing (3)
  • source/administration-guide/configure/experimental-configuration-settings.rst
  • source/deployment-guide/mobile/mobile-security-features.rst
  • source/security-guide/mobile-security.rst
📝 Walkthrough

Walkthrough

This pull request adds documentation for a new experimental mobile watermarking feature across three guides. The changes describe how administrators enable the feature, what authenticated mobile users will observe, and its role in data loss prevention workflows. All additions reference configuration, version availability (v11.7+), and the visual-only, non-blocking nature of the overlay.

Changes

Mobile Watermarking Documentation

Layer / File(s) Summary
Configuration Setting Documentation
source/administration-guide/configure/experimental-configuration-settings.rst
New experimental setting "Enable Mobile Watermark" is documented with the config.json key ExperimentalSettings.EnableMobileWatermark, default false behaviour, Enterprise/v11.7+ availability, and a note on watermark scope and limitations.
Feature Overview and Scope
source/deployment-guide/mobile/mobile-security-features.rst
New "Mobile watermarking" section describes the feature as available from v11.7+, disabled by default, showing username, server domain, date, and time as an overlay for DLP attribution purposes, with explicit limitations that it is visual-only and does not prevent capture/export/sharing, and is mobile-only.
Security and DLP Context
source/security-guide/mobile-security.rst
New "Mobile watermarking" subsection positions the feature as an experimental Enterprise capability (v11.7+) that overlays authenticated sessions for DLP identification, clarifies it does not block screenshots/recordings/exports/sharing, notes it is disabled by default, and links to configuration and feature documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding documentation for an experimental mobile watermarking feature in version 11.7.
Description check ✅ Passed The description is directly related to the changeset, specifying which documentation pages were edited and what content was added regarding the mobile watermarking feature.
Linked Issues check ✅ Passed The PR successfully implements all core coding/documentation requirements: adds the experimental 'Enable Mobile Watermark' setting documentation, describes the watermark overlay content, explains the DLP purpose, avoids overstating protection, and maintains proper scope by documenting only admin/user-visible behavior.
Out of Scope Changes check ✅ Passed All changes are within scope: three documentation files updated to cover the experimental mobile watermarking feature, with no modifications to changelogs, upgrade notes, developer docs, or other restricted areas.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-8953-20260512-0010

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@source/deployment-guide/mobile/mobile-security-features.rst`:
- Around line 59-69: Update the "Mobile watermarking" paragraph to explicitly
state the enterprise plan requirement: indicate that the feature is available
from Mattermost v11.7 onward and is restricted to Enterprise / Enterprise
Advanced deployments (add wording like "Enterprise or Enterprise Advanced only")
so self-hosted non-Enterprise admins are not misled; also mirror the phrasing
used on admin/security pages and ensure the :ref:`Enable Mobile Watermark
<administration-guide/configure/experimental-configuration-settings:enable
mobile watermark>` reference remains intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 645add29-2f83-4240-bccd-cdee90a32cba

📥 Commits

Reviewing files that changed from the base of the PR and between d63b6e0 and 2602efb.

📒 Files selected for processing (3)
  • source/administration-guide/configure/experimental-configuration-settings.rst
  • source/deployment-guide/mobile/mobile-security-features.rst
  • source/security-guide/mobile-security.rst

Comment thread source/deployment-guide/mobile/mobile-security-features.rst Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 2602efb

@Combs7th

Copy link
Copy Markdown
Contributor Author

@claude - Please implement coderabbitai's feedback above.

@claude

claude Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Claude finished @Combs7th's task in 50s —— View job


Implemented CodeRabbit's feedback

  • Read the current state of source/deployment-guide/mobile/mobile-security-features.rst
  • Reviewed phrasing in source/security-guide/mobile-security.rst and source/administration-guide/configure/experimental-configuration-settings.rst for consistency
  • Updated the "Mobile watermarking" paragraph to state Enterprise / Enterprise Advanced scope
  • Confirmed the :ref: link to Enable Mobile Watermark is intact
  • Commit pushed: 87040f2

Change summary

Updated source/deployment-guide/mobile/mobile-security-features.rst:59 so the lead-in sentence now mirrors the wording on the admin and security pages:

-Mobile watermarking is an experimental capability available from Mattermost v11.7 onward that helps organizations…
+Mobile watermarking is an experimental Enterprise capability, available on `Enterprise and Enterprise Advanced plans <https://mattermost.com/pricing/>`__ from Mattermost v11.7 onward, that helps organizations…

This matches the security-guide/mobile-security.rst overview ("experimental Enterprise capability") and the experimental-configuration-settings.rst setting ("Available on Enterprise and Enterprise Advanced plans"), so self-hosted non-Enterprise admins won't be misled. The :ref:Enable Mobile Watermark<...> link in the section is unchanged. • Branch: [claude/issue-8953-20260512-0010`](https://github.com/mattermost/docs/tree/claude/issue-8953-20260512-0010)

Address CodeRabbit review: explicitly state Enterprise and Enterprise
Advanced plan availability in the deployment-guide mobile watermarking
section to mirror the admin and security pages and avoid misleading
self-hosted, non-Enterprise admins.

Co-authored-by: Combs7th <Combs7th@users.noreply.github.com>
@Combs7th Combs7th changed the base branch from master to v11.7-documentation May 12, 2026 00:38
@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 87040f2

@Combs7th Combs7th requested a review from asaadmahmood May 12, 2026 00:42
@Combs7th Combs7th added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels May 12, 2026
@Combs7th Combs7th added this to the v11.7.0 milestone May 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 57868fc

@Combs7th

Combs7th commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

Heya @asaadmahmood: I have a first draft ready for the mobile watermarking docs.

One thing I want to verify before this goes too far: the server PR appears to use ExperimentalSettings.EnableWatermark as the config.json key and exposes it to clients as ExperimentalEnableWatermark. Can you confirm that ExperimentalSettings.EnableWatermark is the correct docs-facing config path?

I also flagged a few quick review points in the PR:

  • whether there’s an environment variable for the setting
  • whether “Enterprise and Enterprise Advanced” is the right plan wording
  • whether enabling/disabling takes effect immediately or requires mobile users to restart/sign out and back in

Once those are confirmed, I think the draft should be in pretty good shape unless there's anything else you think we should add.

@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 20a8b99

@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA a678d63

@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 9f28b95

@amyblais amyblais changed the base branch from v11.7-documentation to master May 15, 2026 06:12
@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 9d29c6b

@Combs7th

Copy link
Copy Markdown
Contributor Author

Hey @asaadmahmood - Just wanted to see if you able to give this one a review? Thanks in advance!

@asaadmahmood asaadmahmood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everywhere we say Enterprise, we should remove that and only say Enterprise Advanced.
And it should also be labelled as an experimental feature.

@esethna

esethna commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@Combs7th are there next steps on this PR?

@Combs7th Combs7th requested review from asaadmahmood and esethna June 23, 2026 03:28
@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 54d2f23

@Combs7th

Copy link
Copy Markdown
Contributor Author

@asaadmahmood - Updated all mentions of Enterprise to Enterprise Advanced, and ensured that we have the feature listed as experimental.

@esethna - This one should be all set after final review.

@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 80f8971

@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 79892ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add docs for experimental mobile watermarking

4 participants