Skip to content

fix(lore): surface quest corpus coverage in lore health - #119

Open
syf2211 wants to merge 1 commit into
mathomhaus:mainfrom
syf2211:fix/lore-health-quest-corpus
Open

fix(lore): surface quest corpus coverage in lore health#119
syf2211 wants to merge 1 commit into
mathomhaus:mainfrom
syf2211:fix/lore-health-quest-corpus

Conversation

@syf2211

@syf2211 syf2211 commented Aug 23, 2026

Copy link
Copy Markdown

Summary

Extend guild lore health and MCP lore_health to report embedder health for both lore and quest corpora in a single command.

Motivation

Operators had no single-command view of embedding health across both stores. lore health only surfaced lore corpus metrics even though quest maintains its own vector tables and quest.* meta keys.

Fixes #91

Changes

  • Add OpenQuestDB to command.Deps and wire it in CLI + MCP lore deps
  • Extend EmbedderHealthCmdOutput with lore_report and quest_report
  • Render separate lore corpus and quest corpus embedder sections with identical metrics
  • When quest.db is unavailable, still render the quest section as 0/0 coverage

Tests

  • go test ./internal/lore/... -run TestEmbedderHealth -count=1 — PASS
  • go test ./internal/lore/... ./internal/cli/... ./internal/mcp/... ./internal/command/... -count=1 — PASS
  • go vet ./... — PASS
  • composer-2.5 review — APPROVE

Notes

  • MCP/CLI JSON output field changed from report to lore_report / quest_report (structured output was not previously documented as stable API)
  • Quest DB read failures degrade to empty 0/0 section rather than failing the whole command

Extend `guild lore health` / MCP `lore_health` to report embedder
metrics for both lore and quest corpora. Quest coverage is read from
quest.db via the existing QuestCorpus adapter; when quest.db is
unavailable the quest section still renders 0/0.

Fixes mathomhaus#91
@github-actions github-actions Bot added area: lore Lore knowledge archive area: mcp MCP server / protocol area: cli CLI surface / cobra verbs labels Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: cli CLI surface / cobra verbs area: lore Lore knowledge archive area: mcp MCP server / protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] lore_health does not surface quest corpus coverage

1 participant