fix(init): skip MCP registration when client CLI is not on PATH - #118
Open
syf2211 wants to merge 1 commit into
Open
fix(init): skip MCP registration when client CLI is not on PATH#118syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
Guild init previously showed config-detected clients in the plan and attempted MCP registration even when the client's CLI binary was missing from PATH. The --run path in MCPInstall already skipped these clients, but the init summary did not surface the skip reason upfront. Partition detected clients into callable vs config-only, show a clear skip line in the init plan, and pass only callable clients to MCPInstall. Avoid the misleading no-client hint when clients were detected but skipped. Fixes mathomhaus#90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guild initnow skips MCP registration for clients detected only via their config file when the corresponding CLI binary is not onPATH, and surfaces that skip in the init plan summary.Motivation
Issue #48 fixed the
--runpath inguild mcp installto skip clients whose install CLI is missing fromPATH.guild initstill listed config-detected clients as pending registration in the plan, which misled users and could lead to opaque exec failures. Fixes #90.Changes
CLIOnPath()andpartitionCallableClients()ininternal/install/clients.goguild init, partition detected clients and showskipping <client>: <binary> not on PATHin the planMCPInstall; avoid the no-client hint when clients were detected but skippedTests
go test ./internal/install/... -count=1All install package tests pass.
Notes
CLIProbe) remain unaffectedguild mcp install --run(not on PATH)