add contributing guidelines#2
Open
vkareh wants to merge 1 commit into
Open
Conversation
lukefromdc
approved these changes
Jun 4, 2026
Member
lukefromdc
left a comment
lukefromdc
left a comment
There was a problem hiding this comment.
Looks good to me. The "every line" standard is what counts. If every line has to be reviewed and understood, that puts a human in the loop for code quality.
Member
|
Is is reasonable to assume all contributors build and run code they submit as a PR or does this have to be specified too? |
vkareh
force-pushed
the
add-contributing-guidelines
branch
from
5ece1ba to
503fbdb
Compare
Member
Author
Good call. I've added a new guideline for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on GitHub's contribution guidelines docs, adding this file here makes it show up in all pull request or issue creation forms.