fix(number-format): honor min/max-fraction-digits of 0#13697
Open
spokodev wants to merge 1 commit into
Open
Conversation
|
Hey, @spokodev 👋 Thanks for your contribution to Mapbox GL JS! Important: This repository does not accept direct merges. All changes go through our internal review process. What happens next:
Please respond to any review comments on this PR. For more details, see CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
number-formatexpression droppedmin-fraction-digitsandmax-fraction-digitswhen they were set to0.At parse time the option is read with a truthiness check:
0is a valid value (the style spec documentsmax-fraction-digitsas themaximum number of fractional digits, and
0is in range), but it is falsy, sothe option was silently ignored and never passed to the formatter.
Concrete case:
["number-format", 3.7, {"max-fraction-digits": 0}]returned"3.7"instead of"4". Formatting a value as an integer is a common need forstyle authors, and they got the wrong label text with no error.
The fix checks
!== undefinedfor the two numeric options. String options areleft unchanged.
Added an expression test covering
max-fraction-digitsof 0.