fix(cli): don't block the UI thread on catalog refresh#850
Open
nickprotop wants to merge 2 commits into
Open
Conversation
RefreshCatalogFromUi (Ctrl+R, refresh button, command palette) blocked the UI thread with LoadCatalogsAsync(...).GetAwaiter().GetResult(). That freezes the render loop for the duration of the network fetch, and hard-deadlocks if a UI SynchronizationContext is installed (the awaited continuation is posted back to the blocked UI thread). Run the refresh off-thread with Task.Run + ConfigureAwait(false), then marshal the result toast and rebuilds back onto the UI thread via EnqueueOnUIThread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interactive command center's
RefreshCatalogFromUi— wired to Ctrl+R, the refresh button, and the command palette — blocked the UI thread on the async catalog fetch:This freezes the render loop and all input for the full duration of the network fetch, so the whole TUI locks up while the catalog refreshes.
Fix
Run the refresh off the UI thread and marshal results back:
Task.Run+ConfigureAwait(false)for the fetch.Session.RaiseSnapshotChanged()+RebuildStatusBar(...)are marshalled onto the UI thread viaEnqueueOnUIThread.No public surface change; the method stays a
voidcallable as anActionfrom every existing call site.Builds clean (
0 Error(s)).