docs: remove external design-system attributions - #7
Merged
Conversation
Rules 6b, 6c and the "Why these names" list cited kumo-ui.com as the source of propel's `variant`/`size` vocabulary. The rules stand on their own reasoning, so drop the attributions. Item 2 of "Why these names" had no justification beyond the Kumo precedent, so it gets one: a caller picks exactly one look, and a separate `color` prop would only make contradictory pairs representable -- the same failure item 1 already describes for the `prominence`/`tone` split.
CLAUDE.md and PRODUCT.md positioned the docs site by naming Radix, Stripe, shadcn and Tailwind. Describe the qualities directly instead, so the guidance does not lean on another project's identity.
bhaveshraja
approved these changes
Aug 25, 2026
bhaveshraja
left a comment
bhaveshraja
left a comment
Collaborator
There was a problem hiding this comment.
Only comments level changes are a addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes citations of other design systems from propel's internal guidance docs, so the conventions stand on their own reasoning.
packages/propel/AGENTS.md— dropped kumo-ui.com as the cited source of thevariant/sizevocabulary (rules 6b, 6c, "Why these names").apps/docs/CLAUDE.md,apps/docs/PRODUCT.md— dropped the Radix/Stripe/shadcn/Tailwind comparisons, describing the intended qualities directly instead.Item 2 of "Why these names" had no justification beyond the Kumo precedent, so it was given one rather than left bare. The rule is unchanged; only its rationale is new — worth a read.
Type of Change