fix: remove deleted programs from program cache - #57
Conversation
a8e52b5 to
bac03c4
Compare
|
Warning Review limit reached
Next review available in: 37 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bac03c4 to
2e15dfe
Compare
What changed
MAX_LOADED_ENTRY_COUNTconstant and document the deletion contract.Closes #53
Impact
Successfully deleted programs no longer leave stale compiled entries in the shared cache. Failed transactions preserve the existing entry. This adds no new public change-set type or Keeper behavior.
Validation
cargo test -p magicblock-engine --test accounts account_program_cache_tracks_v42_lifecyclecargo test -p solana-program-runtime— 52 passedcargo check -p solana-svm -p magic-root-programcargo fmt --checkgit diff --checkReviewer notes
The transaction-local modified-entry map remains last-write-wins. A closed sentinel reaches the shared cache only through the existing successful execution and
access_is_valid()gate. Native builtins remain protected by existing account lifecycle rules.