feat: forked transaction-view for increased limits

[bmuddha]

What changed

Forked agave-transaction-view into the workspace and adapted its framing parser for engine transaction sizes.

Why

Engine-private transactions can exceed packet-sized assumptions, so their zero-copy view must parse complete canonical lengths and validate larger offsets before unchecked access.

Closes #34.

Impact

• Patches the workspace dependency graph to use the local transaction-view fork.
• Replaces the packet-specific two-byte compact-u16 fast path with the complete canonical one-, two-, or three-byte parser.
• Uses checked offset arithmetic and validated byte slices before exposing zero-copy transaction fields.
• Preserves standard Legacy, v0, and V1 wire behavior while documenting the distinct Magicblock size and instruction-trace limits.

Reviewer notes

Unchecked iterators and typed views rely on the initial frame validation. Review the offset and length checks together with the standard-versus-Magicblock limit boundary.

Follow-up

The transaction-context and runtime forks consume this parser upstack.

[bmuddha]

• feat: add state replicator crate on top of the engine #25 : 2 dependent PRs (#37 , #55 )
• feat: adds top level engine crate for global orchestration #24
• feat: added internal built-in magic root program #23
• feat: implement transaction processor crate #22
• feat: implements keeper crate - state orchestrator #17
• feat: implement superblock based ledger crate #15
• feat: add optimized accountsdb crate #14
• feat: add nucleus engine crate #18
• feat: add svm crate #21
• feat: add program runtime crate #20
• feat: add transaction context crate #19
• feat: forked transaction-view for increased limits #33 👈 (View in Graphite)
• feat: add customized solana-account crate #13
• chore: import upstream Solana runtime crates #31
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9054af40-1098-445c-a69e-0e7d0f9b5a00

📥 Commits

Reviewing files that changed from the base of the PR and between 86c2748 and 7b6cfcd.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

• Cargo.toml
• solana/transaction-view/README.md
• solana/transaction-view/src/instructions_frame.rs

🚧 Files skipped from review as they are similar to previous changes (2)

• solana/transaction-view/README.md
• solana/transaction-view/src/instructions_frame.rs

---

📝 Walkthrough

Walkthrough

The pull request registers a local agave-transaction-view fork, updates its package and workspace integration, adds documentation, checks offset arithmetic before access, and bounds unsafe typed accessors before pointer conversion. Most other changes reformat implementation and test code.

Changes

Transaction view fork

Layer / File(s)	Summary
Workspace integration and package metadata Cargo.toml, solana/transaction-view/Cargo.toml, solana/transaction-view/README.md, solana/transaction-view/benches/*	The workspace registers the local fork, updates Solana dependencies, applies the local patch, declares package version 4.1.1, and documents supported formats and limits.
Checked byte and instruction parsing solana/transaction-view/src/bytes.rs, solana/transaction-view/src/instructions_frame.rs	Byte readers return ParseError when offset arithmetic overflows. Instruction-frame construction and iterator tests use the updated serialization and offset.
Bounded zero-copy views and supporting validation solana/transaction-view/src/transaction_frame.rs, solana/transaction-view/src/transaction_view.rs, solana/transaction-view/src/sanitize.rs, solana/transaction-view/src/resolved_transaction_view.rs	Pubkey and Hash references are created from bounded slices before casting. Related validation, view, resolved-view, and test expressions are reformatted without behavior changes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant TransactionBytes
  participant ByteReaders
  participant InstructionFrames
  participant Sanitizer
  TransactionBytes->>ByteReaders: Read bytes and compact-u16 lengths
  ByteReaders-->>InstructionFrames: Return parsed values or ParseError
  InstructionFrames->>Sanitizer: Provide parsed frame metadata
  Sanitizer-->>InstructionFrames: Validate transaction limits

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the forked transaction-view and its purpose of supporting increased transaction limits.
Description check	✅ Passed	The description directly explains the transaction-view fork, parser changes, validation safeguards, limits, and linked issue.
Linked Issues check	✅ Passed	The changes register and patch the fork, add checked parsing and access, preserve wire formats, and document distinct transaction limits.
Out of Scope Changes check	✅ Passed	The dependency, parser, safety, documentation, and formatting changes support the linked issue objectives; no unrelated changes are evident.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch transaction-view

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[bmuddha]

@CodeRabbit review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Cargo.toml`:
- Around line 50-55: Align the version requirements for agave-transaction-view
in the root dependency configuration and solana/transaction-view/Cargo.toml so
the local [patch.crates-io] entry applies. Preserve the intended local fork
resolution by making the declared dependency version compatible with the patched
package version.

In `@solana/transaction-view/README.md`:
- Around line 27-30: Update the transaction size and signature-limit
documentation to distinguish parser-enforced boundaries from
sanitization-enforced limits. In the README section describing Legacy, v0, V1,
and Magicblock transactions, state that Legacy parsing rejects the
over-signature case through TransactionView::try_new_unsanitized with
ParseError, while V1 signature validation occurs in sanitize_signatures; keep
other structural sanitization limits described separately.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b02b19fe-fd5a-4abe-bbf8-733802fe596c

📥 Commits

Reviewing files that changed from the base of the PR and between c684aa7 and 86c2748.

📒 Files selected for processing (11)

• Cargo.toml
• solana/transaction-view/Cargo.toml
• solana/transaction-view/README.md
• solana/transaction-view/benches/bytes.rs
• solana/transaction-view/benches/transaction_view.rs
• solana/transaction-view/src/bytes.rs
• solana/transaction-view/src/instructions_frame.rs
• solana/transaction-view/src/resolved_transaction_view.rs
• solana/transaction-view/src/sanitize.rs
• solana/transaction-view/src/transaction_frame.rs
• solana/transaction-view/src/transaction_view.rs