Improve devcontainer setup - #7
Open
maazghani wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dockerfileso the dev environment can be built and iterated without touching the production image.Description
.devcontainer/Dockerfilebased on the official Dev Containers Node 22 Bookworm image with pinnedpnpm,git, andopenssh-clientandNEXT_TELEMETRY_DISABLEDset..devcontainer/devcontainer.jsonto build from the new devcontainerDockerfilewith.devcontaineras the buildcontextand expose buildargsforNODE_VERSIONandPNPM_VERSION.mountsand setpostCreateCommandto configure the pnpm store and install dependencies.postAttachCommandto register the workspace as a safe Git directory and includecontainerEnventries and existing port forwarding and VS Code extensions.Testing
pnpm testwhich executed the Vitest suite and reported all tests passing..devcontainer/devcontainer.jsonwithpython3 -m json.toolwhich succeeded.docker build -f .devcontainer/Dockerfile .devcontainerbut the environment does not havedockeravailable so the image build could not be executed here.Codex Task