[WRONG BRANCH] fix(routing): avoid unbound Codex quota evidence - #21
[WRONG BRANCH] fix(routing): avoid unbound Codex quota evidence#21luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
✅ Deterministic PR hygiene checks passed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42d7cb065b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| accountRef: candidate.provider === "anthropic" | ||
| ? getAccountSet("anthropic")?.activeAccountId | ||
| : undefined, |
There was a problem hiding this comment.
Update the quota-routing documentation
For Pool-mode OpenAI profiles, this now deliberately leaves runtime quota evidence unknown unless an account-qualified dry-run supplies codexAccountId, but docs-site/src/content/docs/reference/configuration/routing.md:155-164 still states that runtime routing reads quota for the selected Pool account. Users configuring optimize.quota or require.minQuotaHeadroom will therefore expect account-aware decisions that no longer occur; update the English documentation and applicable translations to describe the new account-unbound behavior.
AGENTS.md reference: src/AGENTS.md:L28-L28
Useful? React with 👍 / 👎.
Motivation
Description
src/router.tsso candidates without an explicit account keep unknown quota evidence until an account-qualified selector binds one.src/server/management/routing-profile-routes.tsso evaluate/dry-run results mirror real routing behavior.tests/quota-scoring.test.tsto assert that policy dry-run/route decisions do not invent Codex pool quota evidence for account-unbound candidates.anthropic/explicit account refs.Testing
./node_modules/.bin/bun test tests/quota-scoring.test.tsand the quota tests passed (9 tests across the file passed)../node_modules/.bin/bun test tests/route-explainability.test.tsand those tests passed (10 tests passed).bun run typecheckwhich succeeded../node_modules/.bin/bun scripts/privacy-scan.tswhich reported "Privacy scan passed."../node_modules/.bin/bun scripts/test.ts; this run surfaced unrelated environment/baseline failures in API-key attribution and combo-management tests and HTTP 403s when fetching GUI dependencies, so the full-suite run was not used to block this focused fix.bun testusing the system Bun (v1.2.14) errored due to a missingnode:zlibexport; using the repository-installed Bun (v1.3.14) produced the passing results above.