[WRONG BRANCH] fix(grok): report non-durable toggles - #15
Conversation
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab3e0e4279
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| message: result.changed | ||
| ? "Grok integration disabled — the opencodex block was removed. Re-enabling regenerates it from the current model list." | ||
| : "Grok integration is already off", | ||
| ...(durable ? {} : { reason: "not_durable" }), |
There was a problem hiding this comment.
Surface the non-durable outcome in the dashboard
When $OPENCODEX_HOME/config.json is absent and Grok is disabled from the dashboard, this new reason is returned but gui/src/pages/integrations/IntegrationsOverview.tsx only displays the two non_loopback_* reasons and otherwise leaves the card result empty. The user therefore still sees the switch turn off without learning that the next startup will use the default enabled intent and recreate the fence. Handle not_durable in toggleCard with localized warning copy and add coverage for that consumer path.
Useful? React with 👍 / 👎.
Motivation
config.jsonis missing, avoiding a misleading “durable” success message.Description
reason: "not_durable"in the Grok enable and disable success envelopes when the persisted intent was not durable. (Updated success responses insrc/server/management/native-integration-routes.ts.)reason: "not_durable"when a config snapshot is missing. (Added test intests/native-grok-toggle.test.ts.)Testing
./node_modules/.bin/bun test tests/native-grok-toggle.test.ts tests/codex-desired-state.test.tsand the focused suite passed (44 passed, 0 failed)../node_modules/.bin/bun run typecheckand./node_modules/.bin/bun run privacy:scan, both of which completed successfully../node_modules/.bin/bun run test) was executed but encountered unrelated existing failures intests/server-auth.test.tsandtests/service.test.ts; the change itself is covered by the focused tests which passed.