Skip to content

[WRONG BRANCH] fix(grok): report non-durable toggles - #15

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-grok-toggle-success-response-handling
Draft

[WRONG BRANCH] fix(grok): report non-durable toggles#15
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-grok-toggle-success-response-handling

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Ensure the Grok management toggle honestly reports when a change was applied but could not be persisted because the user's config.json is missing, avoiding a misleading “durable” success message.

Description

  • Include reason: "not_durable" in the Grok enable and disable success envelopes when the persisted intent was not durable. (Updated success responses in src/server/management/native-integration-routes.ts.)
  • Add a route-level regression test that exercises both disable and enable paths and asserts the envelope includes reason: "not_durable" when a config snapshot is missing. (Added test in tests/native-grok-toggle.test.ts.)
  • Change is narrowly scoped to reporting; no alteration of persistence semantics or ownership checks was made.

Testing

  • Ran the focused unit tests with ./node_modules/.bin/bun test tests/native-grok-toggle.test.ts tests/codex-desired-state.test.ts and the focused suite passed (44 passed, 0 failed).
  • Ran static and project checks with ./node_modules/.bin/bun run typecheck and ./node_modules/.bin/bun run privacy:scan, both of which completed successfully.
  • The full test suite (./node_modules/.bin/bun run test) was executed but encountered unrelated existing failures in tests/server-auth.test.ts and tests/service.test.ts; the change itself is covered by the focused tests which passed.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 590e5ad3-90b4-4c73-aee7-03efa68bc105

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and ab3e0e4.

📒 Files selected for processing (2)
  • src/server/management/native-integration-routes.ts
  • tests/native-grok-toggle.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix(grok): report non-durable toggles [WRONG BRANCH] fix(grok): report non-durable toggles Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 05:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab3e0e4279

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

message: result.changed
? "Grok integration disabled — the opencodex block was removed. Re-enabling regenerates it from the current model list."
: "Grok integration is already off",
...(durable ? {} : { reason: "not_durable" }),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Surface the non-durable outcome in the dashboard

When $OPENCODEX_HOME/config.json is absent and Grok is disabled from the dashboard, this new reason is returned but gui/src/pages/integrations/IntegrationsOverview.tsx only displays the two non_loopback_* reasons and otherwise leaves the card result empty. The user therefore still sees the switch turn off without learning that the next startup will use the default enabled intent and recreate the fence. Handle not_durable in toggleCard with localized warning copy and add coverage for that consumer path.

Useful? React with 👍 / 👎.

@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant