fix: allow completion command without storage config#1158
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: allow completion command without storage config#1158AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
The generated completion command (and its subcommands) ran through PersistentPreRunE, which requires a configured storage type and password, so 'scrt completion bash' failed with 'missing storage type'. Short-circuit the completion command and its children so generating shell completion does not require a store. Added a regression test. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated completion command ran through PersistentPreRunE, which requires a storage type and password, so 'scrt completion bash' failed with 'missing storage type'. The completion command and its subcommands now short-circuit that validation. Added a regression test that asserts PersistentPreRunE returns nil for completion and its bash subcommand.