http: hand back response body without copying it#3
Merged
Conversation
Extract the HTTP body by reusing the response buffer's allocation (split_off) instead of copying the whole tail into a fresh Vec. On the payload download this drops a full-length memcpy and roughly halves peak memory for the transfer. The returned bytes are identical, so admission and measurement are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the stage0 boot-path security review (buffer-duplication pass).
http::requestextracted the response body withraw[sep + 4..].to_vec(), copying the whole tail into a freshVecand then droppingraw. On the payload download that is a full-length memcpy and roughly 2x peak memory for the transfer. This switches toraw.split_off(sep + 4), which reuses the existing allocation and hands back the tail directly.No behavior change: the returned bytes are identical, so admission (sha256 / ed25519) and PCR 14 measurement are unaffected.
Verified:
make boot-x86_64boots the full chain (payload downloaded, admitted, measured, chain-loaded) and fails closed as expected.🤖 Generated with Claude Code