-
Notifications
You must be signed in to change notification settings - Fork 9
fix(extensions): tolerate ClientFactory<T> constructor change in AWS SDK 4.0.4+ (#52) #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f9fb9e4
chore(deps): refresh dependencies and add AWS SDK compatibility tracks
Blind-Striker d53d2c5
fix(extensions): tolerate ClientFactory<T> ctor change in AWS SDK 4.0β¦
Blind-Striker 91f868e
ci: modernize workflows and add AWS SDK canary
Blind-Striker 3c63ac6
ci: install Mono on the macOS runner for net472 tests
Blind-Striker c3176a1
test(functional): guarantee per-test resource teardown in shared contβ¦
Blind-Striker 1fc7ab6
fix(build): repair package version generation for GitHub Packages
Blind-Striker 13aa298
fix(ci): sanitise branch name used for the package artifact
Blind-Striker 90269eb
ci: isolate the legacy AWS SDK leg and stop tracking .mcp.json
Blind-Striker 8da194b
refactor(build): simplify AWS SDK tracks and pin the toolchain to .NET 9
Blind-Striker f539bf4
release: prepare LocalStack.Client.Extensions 2.0.1
Blind-Striker 4bb0fa7
build: retire LocalStack.sln in favour of the slnx
Blind-Striker d8c3de1
docs(readme): record the AWS SDK 4.0.4 breakage as a known issue
Blind-Striker cba7309
fix(functional): only treat a missing stack as successful teardown
Blind-Striker 47a6740
fix(extensions): expand generic arguments in the constructor diagnostic
Blind-Striker 0aa4c9b
docs(functional): record the measured CloudFormation delete response
Blind-Striker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| name: "AWS SDK Canary" | ||
|
|
||
| # Early warning for AWS SDK drift. | ||
| # | ||
| # The normal build pins AWSSDK.* so it stays reproducible - which is exactly why the | ||
| # AWSSDK.Extensions.NETCore.Setup 4.0.4 breaking change (issue #52) went unnoticed for 70 days: | ||
| # CI only ever saw the pinned version, while consumers float to whatever is newest. | ||
| # | ||
| # This job floats both AWSSDK.Core and AWSSDK.Extensions.NETCore.Setup to the latest 4.x and runs | ||
| # the suite against them. A failure here means "AWS moved", not "we broke something". | ||
|
|
||
| on: | ||
| schedule: | ||
| # 05:00 UTC daily | ||
| - cron: "0 5 * * *" | ||
| workflow_dispatch: | ||
|
|
||
| env: | ||
| DOTNET_CLI_TELEMETRY_OPTOUT: true | ||
| DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true | ||
| DOTNET_NOLOGO: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| canary: | ||
| name: "Latest AWS SDK" | ||
| runs-on: ubuntu-22.04 | ||
| if: github.repository == 'localstack-dotnet/localstack-dotnet-client' | ||
|
|
||
| steps: | ||
| - name: "Checkout" | ||
| uses: actions/checkout@v7 | ||
|
|
||
| - name: "Setup .NET SDK" | ||
| uses: actions/setup-dotnet@v6 | ||
| with: | ||
| dotnet-version: | | ||
| 8.0.x | ||
| 9.0.x | ||
| global-json-file: global.json | ||
|
|
||
| # Floating versions resolve against NuGet's cached feed index, so a warm HTTP cache can pin this | ||
| # job to a stale "latest" without saying so - the exact drift it exists to detect. | ||
| - name: "Clear NuGet HTTP cache" | ||
| run: dotnet nuget locals http-cache --clear | ||
|
|
||
| # Deliberately no NuGet package cache either: the point is to resolve the newest AWSSDK every run. | ||
| - name: "Build & test against floating AWS SDK" | ||
| run: ./build.sh --target tests --skipFunctionalTest true --aws-setup-track latest --force-restore true --exclusive | ||
|
|
||
| - name: "Report resolved AWS SDK versions" | ||
| if: always() | ||
| run: | | ||
| echo "### Resolved AWS SDK versions" >> $GITHUB_STEP_SUMMARY | ||
| echo '```' >> $GITHUB_STEP_SUMMARY | ||
| grep -rhoE '"AWSSDK\.(Extensions\.NETCore\.Setup|Core)/[^"]+"' \ | ||
| tests/*/obj/project.assets.json 2>/dev/null | sort -u >> $GITHUB_STEP_SUMMARY || true | ||
| echo '```' >> $GITHUB_STEP_SUMMARY | ||
|
|
||
| - name: "Upload test artifacts" | ||
| uses: actions/upload-artifact@v7 | ||
| if: failure() | ||
| with: | ||
| name: canary-test-results | ||
| path: | | ||
| **/*.trx | ||
| **/TestResults/**/* | ||
| retention-days: 7 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.