Fix llvm-symbolizer test broken by #199739#199801
Open
sbc100 wants to merge 1 commit into
Open
Conversation
I was not aware that `wasm-ld` had testing outside of `lld/test/wasm`.
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Sam Clegg (sbc100) ChangesI broke this test in #199739. As a result to that change, the start of the CODE section in the linked WASM file shifted from 0x41 to 0x37 (a shift of -10 bytes). I was not aware that Full diff: https://github.com/llvm/llvm-project/pull/199801.diff 1 Files Affected:
diff --git a/llvm/test/tools/llvm-symbolizer/wasm-basic.s b/llvm/test/tools/llvm-symbolizer/wasm-basic.s
index bae078aacca85..d0c4f86688b20 100644
--- a/llvm/test/tools/llvm-symbolizer/wasm-basic.s
+++ b/llvm/test/tools/llvm-symbolizer/wasm-basic.s
@@ -3,9 +3,9 @@
# RUN: llvm-symbolizer --basenames --output-style=GNU -e %t.o 0 1 2 3 4 5 6 7 8 9 10 11 12 13 16 | FileCheck %s
# This is the same test but on a linked wasm file, using file offsets rather than section offsets.
-# The code section starts at 0x41, so these are equivalent to above (except 3, see below for why).
+# The code section starts at 0x37, so these are equivalent to above (except 3, see below for why).
# RUN: wasm-ld %t.o -o %t.wasm --no-entry --export=foo --export=bar
-# RUN: llvm-symbolizer --basenames --output-style=GNU -e %t.wasm 3 0x42 0x43 0x44 0x45 0x46 0x47 0x48 0x49 0x4a 0x4b 0x4c 0x4d 0x4e 0x51 | FileCheck %s
+# RUN: llvm-symbolizer --basenames --output-style=GNU -e %t.wasm 3 0x38 0x39 0x3a 0x3b 0x3c 0x3d 0x3e 0x3f 0x40 0x41 0x42 0x43 0x44 0x47 | FileCheck %s
.globl foo
foo:
|
dschuff
approved these changes
May 27, 2026
Member
dschuff
left a comment
There was a problem hiding this comment.
LGTM. We should probably fix this. It's considered a layering violation to have tests of llvm/tools depend on wasm-ld. But this is fine for now to avoid breaking the tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I broke this test in #199739. As a result to that change, the start of the CODE section in the linked WASM file shifted from 0x41 to 0x37 (a shift of -10 bytes).
I was not aware that
wasm-ldhad testing outside oflld/test/wasm.