Skip to content

Fix llvm-symbolizer test broken by #199739#199801

Open
sbc100 wants to merge 1 commit into
llvm:mainfrom
sbc100:fix_symbolizer_test
Open

Fix llvm-symbolizer test broken by #199739#199801
sbc100 wants to merge 1 commit into
llvm:mainfrom
sbc100:fix_symbolizer_test

Conversation

@sbc100
Copy link
Copy Markdown
Contributor

@sbc100 sbc100 commented May 27, 2026

I broke this test in #199739. As a result to that change, the start of the CODE section in the linked WASM file shifted from 0x41 to 0x37 (a shift of -10 bytes).

I was not aware that wasm-ld had testing outside of lld/test/wasm.

I was not aware that `wasm-ld` had testing outside of `lld/test/wasm`.
@llvmorg-github-actions
Copy link
Copy Markdown

@llvm/pr-subscribers-llvm-binary-utilities

Author: Sam Clegg (sbc100)

Changes

I broke this test in #199739. As a result to that change, the start of the CODE section in the linked WASM file shifted from 0x41 to 0x37 (a shift of -10 bytes).

I was not aware that wasm-ld had testing outside of lld/test/wasm.


Full diff: https://github.com/llvm/llvm-project/pull/199801.diff

1 Files Affected:

  • (modified) llvm/test/tools/llvm-symbolizer/wasm-basic.s (+2-2)
diff --git a/llvm/test/tools/llvm-symbolizer/wasm-basic.s b/llvm/test/tools/llvm-symbolizer/wasm-basic.s
index bae078aacca85..d0c4f86688b20 100644
--- a/llvm/test/tools/llvm-symbolizer/wasm-basic.s
+++ b/llvm/test/tools/llvm-symbolizer/wasm-basic.s
@@ -3,9 +3,9 @@
 # RUN: llvm-symbolizer --basenames --output-style=GNU -e %t.o 0 1 2 3 4 5 6 7 8 9 10 11 12 13 16 | FileCheck %s
 
 # This is the same test but on a linked wasm file, using file offsets rather than section offsets.
-# The code section starts at 0x41, so these are equivalent to above (except 3, see below for why).
+# The code section starts at 0x37, so these are equivalent to above (except 3, see below for why).
 # RUN: wasm-ld %t.o -o %t.wasm --no-entry --export=foo --export=bar
-# RUN: llvm-symbolizer --basenames --output-style=GNU -e %t.wasm 3 0x42 0x43 0x44 0x45 0x46 0x47 0x48 0x49 0x4a 0x4b 0x4c 0x4d 0x4e 0x51 | FileCheck %s
+# RUN: llvm-symbolizer --basenames --output-style=GNU -e %t.wasm 3 0x38 0x39 0x3a 0x3b 0x3c 0x3d 0x3e 0x3f 0x40 0x41 0x42 0x43 0x44 0x47 | FileCheck %s
 
 .globl foo
 foo:

Copy link
Copy Markdown
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably fix this. It's considered a layering violation to have tests of llvm/tools depend on wasm-ld. But this is fine for now to avoid breaking the tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants