[RISCV][P-ext] Remove duplicate hasSideEffects=0, mayLoad=0, mayStore=0. NFC#199798
Open
topperc wants to merge 1 commit into
Open
[RISCV][P-ext] Remove duplicate hasSideEffects=0, mayLoad=0, mayStore=0. NFC#199798topperc wants to merge 1 commit into
topperc wants to merge 1 commit into
Conversation
…=0. NFC We had a let outside the class and inside.
|
@llvm/pr-subscribers-backend-risc-v Author: Craig Topper (topperc) ChangesWe had a let outside the class and inside. Full diff: https://github.com/llvm/llvm-project/pull/199798.diff 1 Files Affected:
diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoP.td b/llvm/lib/Target/RISCV/RISCVInstrInfoP.td
index 37c33d27647bf..c0beb6b891284 100644
--- a/llvm/lib/Target/RISCV/RISCVInstrInfoP.td
+++ b/llvm/lib/Target/RISCV/RISCVInstrInfoP.td
@@ -284,10 +284,6 @@ class RVPWideningShift_ri<bits<3> f, string opcodestr, Operand ImmType>
let Inst{11-8} = rd{4-1};
let Inst{7} = 0b0;
let Inst{6-0} = OPC_OP_IMM_32.Value;
-
- let hasSideEffects = 0;
- let mayLoad = 0;
- let mayStore = 0;
}
class RVPWideningShiftW_ri<bits<3> f, string opcodestr>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a let outside the class and inside.