Add customizable environment and volume options#162
Open
brycircle wants to merge 2 commits into
Open
Conversation
Lets operators inject secrets (Redis password, API keys, etc.) via
secretKeyRef or envFrom without rendering them into the plaintext
ConfigMap. LiveKit substitutes ${VAR} in its YAML config at startup,
so values.yaml can reference these env vars instead of literals.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope this is of use to y'all
TLDR;
Enhance LiveKit Helm chart with
extraEnv,extraEnvFrom,extraVolumes, andextraVolumeMountsto allow flexible configuration and secure secret injection. This provides advanced customization capabilities for the LiveKit server deployment.Review Focus
Verify the templating logic for
extraEnv,extraEnvFrom,extraVolumes, andextraVolumeMountscorrectly integrates into the deployment manifest.How to Test
Deploy the chart with custom values for
extraEnv,extraEnvFrom,extraVolumes, andextraVolumeMounts, then inspect the resulting Kubernetes deployment for correct application.