Add notebooks to GitHub actions#542
Draft
mj-gomes wants to merge 2 commits into
Draft
Conversation
Collaborator
|
Hi @mj-gomes, thanks for initiating this! As a matter of fact, these days I did something similar to test the notebooks on another repo, so I might be able to help with this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As discussed in the last meeting, we need to put the notebooks as part of the CI tests. This PR creates a new separate workflow for notebook tests, using nbmake. I added it as a separate workflow because it can be slow, since notebooks often need large enough simulations to be able to show maps etc. This way, it runs in parallel with the other tests.
For commits where we want to skip the notebook tests, we can add [skipnb] or [skip nb] to the commit name.
I also fixed somes bugs in the notebooks that were leading to fails due to some lack of updates on the notebooks with the recent changes in lbs.
Please note:
After these two things, I believe this PR will be ready to go. For now, I leave it as a draft.