Replay MPI_COMM_GRID PR#539
Open
ggalloni wants to merge 1 commit into
Open
Conversation
Replays the mpi_cleanup work from PR #427 on top of current master: stop supporting unused MPI processes and drop the MPI_COMM_GRID / COMM_OBS_GRID / COMM_NULL indirection (COMM_OBS_GRID was always MPI.COMM_WORLD). Observation now raises when comm.size != n_blocks_det * n_blocks_time. Adds None-safe no_mueller_hwp()/no_jones_hwp() helpers to fix the #364 crashes, and widens the detector-dict annotation so `ty` passes. Refs #427, #364, #372.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @anand-avinash, here I replayed the changes from your #427, but on the current master, as the merging was a bit painful. This is linked to a couple of issues and PRs still open, so it would be nice to tackle it at some point.
Let me know what you think and if I can give any further help in completing the work.
Comment from Claude:
MPI_COMM_GRIDcleanup #427 on top of current master: stop supporting unused MPI processes and drop the MPI_COMM_GRID / COMM_OBS_GRID / COMM_NULL indirection (COMM_OBS_GRID was always MPI.COMM_WORLD). Observation now raises when comm.size != n_blocks_det * n_blocks_time.typasses.Refs #427, #364, #372.