openmediavault: define getConfigValue helper - #979
Merged
Conversation
The ignore_tls change called getConfigValue assuming it exists on the base SupportedApps class, but each app defines its own copy (the base class only has static configValue). Without this every RPC request fatals with an undefined-method error. Same helper as Proxmox/Portainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #977:
getConfigValueis not defined on the baseSupportedAppsclass — apps that use it (Proxmox, Portainer, TrueNAS, ...) each define their own copy. Without this, every openmediavault request fatals with an undefined-method error. Adds the same helper used by the other apps.