Skip to content

x11: fix client left at (0,0) inside its frame after WM restart (titlebar drawn behind the client) #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
science wants to merge 1 commit into
base: master
Choose a base branch
from
Open

x11: fix client left at (0,0) inside its frame after WM restart (titlebar drawn behind the client) #841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/x11/window-x11.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,23 @@ meta_window_x11_manage (MetaWindow *window)
priv->client_rect = window->rect;
window->buffer_rect = window->rect;

/* If the window was reparented into a frame above, the client now sits
* at (child_x, child_y) == (0, 0) inside the frame — not at its
* pre-manage root coordinates. client_rect.x/y are compared against
* frame-relative coordinates in meta_window_x11_move_resize_internal,
* so seed them with the real frame-relative position. Seeding root
* coordinates instead skips the initial client move whenever they
* happen to equal (borders.total.left, borders.total.top) — e.g. a
* window returned to the root by the save-set during a WM restart,
* whose frame sat at the screen origin — leaving the client stuck at
* (0, 0) covering its own titlebar.
*/
if (window->frame)
{
priv->client_rect.x = window->frame->child_x;
priv->client_rect.y = window->frame->child_y;
}

if (!window->override_redirect)
{
MetaRectangle rect;
Expand Down