perf(appstream): reuse metadata pool

desktopintegration.cpp

@@ -15,13 +15,11 @@
 #include <appinfo.h>
 #include <appmgr.h>
 
 #include <xdgactivation.h>
 
-#include <AppStreamQt/pool.h>
-
 #include "appwiz.h"
 #include "ddedock.h"
 #include "appearance.h"
 
 DCORE_USE_NAMESPACE
 
@@ -91,38 +89,22 @@
 {
     if (m_compulsoryAppIdList.contains(desktopId)) return true;
 
-#ifdef NO_APPSTREAM_QT
-    Q_UNUSED(desktopId)
-#else
     const QString currentDE(DesktopIntegration::currentDE());
 
-    AppStream::Pool pool;
-    // qDebug() << pool.flags() << currentDE;
-    pool.load();
-
-    const AppStream::ComponentBox components = pool.componentsByLaunchable(AppStream::Launchable::KindDesktopId, desktopId);
+    const AppStream::ComponentBox components = m_appStreamPool.componentsByLaunchable(AppStream::Launchable::KindDesktopId, desktopId);
     for (const AppStream::Component & component : components) {
         return component.compulsoryForDesktops().contains(currentDE);
     }
-#endif
 
     return false;
 }
 
 bool DesktopIntegration::appIsDummyPackage(const QString &desktopId)
 {
-#ifdef NO_APPSTREAM_QT
-    Q_UNUSED(desktopId)
-#else
-    AppStream::Pool pool;
-    // qDebug() << pool.flags();
-    pool.load();
-
-    const AppStream::ComponentBox components = pool.componentsByLaunchable(AppStream::Launchable::KindDesktopId, desktopId);
+    const AppStream::ComponentBox components = m_appStreamPool.componentsByLaunchable(AppStream::Launchable::KindDesktopId, desktopId);
     for (const AppStream::Component & component : components) {
         return component.customValue("DDE::is_dummy_package") == "true";
     }
-#endif
 
     return false;
 }
@@ -232,12 +214,22 @@
 
 DesktopIntegration::DesktopIntegration(QObject *parent)
     : QObject(parent)
+    , m_appStreamPool(this)
     , m_appWizIntegration(new AppWiz(this))
     , m_dockIntegration(new DdeDock(this))
     , m_appearanceIntegration(new Appearance(this))
     , m_iconScaleFactor(1.0)
 {
     qCDebug(logDesktopIntegration) << "Initializing DesktopIntegration";
+    m_appStreamPool.addFlags(AppStream::Pool::FlagMonitor);
+    if (!m_appStreamPool.load()) {
+        qCWarning(logDesktopIntegration) << "Failed to load AppStream metadata:" << m_appStreamPool.lastError();
+    }
+    connect(&m_appStreamPool, &AppStream::Pool::changed, this, [this] {
+        ++m_dummyPackagesRevision;
+        Q_EMIT dummyPackagesChanged();
+    });
+
     QScopedPointer<DConfig> dconfig(DConfig::create("org.deepin.dde.shell", "org.deepin.ds.launchpad"));
     Q_ASSERT_X(dconfig->isValid(), "DConfig", "DConfig file is missing or invalid");
     // TODO:
@@ -268,6 +260,11 @@
     connect(m_appearanceIntegration, &Appearance::opacityChanged, this, &DesktopIntegration::opacityChanged);
 }
 
+uint DesktopIntegration::dummyPackagesRevision() const
+{
+    return m_dummyPackagesRevision;
+}
+
 double DesktopIntegration::scaleFactor() const
 {
     return m_appearanceIntegration->scaleFactor();

desktopintegration.h

@@ -1,13 +1,14 @@
-// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2023 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
 #pragma once
 
 #include <QObject>
 #include <QRect>
 #include <QStandardPaths>
 #include <QtQml/qqml.h>
+#include <AppStreamQt/pool.h>
 
 class AppWiz;
 class DdeDock;
@@ -23,6 +24,7 @@
     Q_PROPERTY(qreal opacity READ opacity NOTIFY opacityChanged FINAL)
     Q_PROPERTY(double scaleFactor READ scaleFactor NOTIFY scaleFactorChanged FINAL)
     Q_PROPERTY(qreal iconScaleFactor READ iconScaleFactor WRITE setIconScaleFactor NOTIFY iconScaleFactorChanged FINAL)
+    Q_PROPERTY(uint dummyPackagesRevision READ dummyPackagesRevision NOTIFY dummyPackagesChanged FINAL)
 
     QML_NAMED_ELEMENT(DesktopIntegration)
     QML_SINGLETON
@@ -57,6 +59,7 @@
     QRect dockGeometry() const;
     uint dockSpacing() const;
     QString backgroundUrl() const;
+    uint dummyPackagesRevision() const;
 
     Q_INVOKABLE bool isDockedApp(const QString & desktopId) const;
     Q_INVOKABLE void sendToDock(const QString & desktopId);
@@ -81,11 +84,14 @@
     void opacityChanged();
     void scaleFactorChanged();
     void iconScaleFactorChanged();
+    void dummyPackagesChanged();
 
 private:
     explicit DesktopIntegration(QObject * parent = nullptr);
 
     QStringList m_compulsoryAppIdList;
+    AppStream::Pool m_appStreamPool;
+    uint m_dummyPackagesRevision = 0;
     AppWiz * m_appWizIntegration;
     DdeDock * m_dockIntegration;
     Appearance * m_appearanceIntegration;

qml/Helper.qml

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -41,6 +41,8 @@ QtObject {
     }
 
     function generateDragMimeData(desktopId, dockOnly = false) {
+        // Re-evaluate this binding when monitored AppStream metadata changes.
+        DesktopIntegration.dummyPackagesRevision
         // In some cases an app is not allowed to be pinned onto dock via drag-n-drop;
         // We only insert the MIME data for dde-dock in those allowed cases.
         let mime = {}