refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#241
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePins the ansible.posix collection dependency to version 2.1.0 to maintain compatibility with EL7 while keeping existing community.general constraints unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a brief inline comment in
collection-requirements.ymlnext to theansible.posixversion pin to document the EL7 compatibility reason, so future updates don’t inadvertently break EL7 support. - If EL7 compatibility allows some flexibility, you might want to specify a compatible version range (e.g.,
<2.2.0) instead of pinning to exactly2.1.0to ease future maintenance while still avoiding the known-bad release.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief inline comment in `collection-requirements.yml` next to the `ansible.posix` version pin to document the EL7 compatibility reason, so future updates don’t inadvertently break EL7 support.
- If EL7 compatibility allows some flexibility, you might want to specify a compatible version range (e.g., `<2.2.0`) instead of pinning to exactly `2.1.0` to ease future maintenance while still avoiding the known-bad release.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
052c02e to
6060b28
Compare
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
6060b28 to
174366d
Compare
Jakuje
left a comment
There was a problem hiding this comment.
not sure whats up with the CI though.
rate limit exceeded because PRs to all repos got pushed at once. Next time we'll use [citest_skip] to make coderabbit ignore such PRs. |
The recently released ansible.posix 2.2.0 does not work on EL7. Pin the version of ansible.posix to 2.1.X. NOTE: Even though this role might not support EL7, this update is applied to all system roles for consistency. Plus, when this role is part of the system roles collection, all roles must use the same version of ansible.posix - there is no way for a role which is part of a collection to use a different version of a dependency than the version used by the other roles. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
174366d to
6e379cc
Compare
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.
NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.