ci: Use generalized action to test against different distributions#240
ci: Use generalized action to test against different distributions#240spetrosi wants to merge 2 commits into
Conversation
Add comprehensive CodeRabbit configuration enforcing linux-system-roles coding standards including: - Conventional Commits for PR titles - PR description template validation - no_log parametrization patterns - OSTree compatibility for package installation - Template header requirements - Variable naming conventions - Test coverage requirements - Idempotency and check mode support Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Enhancement: Use single GH action to test on container images Reason: The fleet of GH actions testing against different container images was not maintainable. Result: On this role side, all code is in one workflow file. Issue Tracker Tickets (Jira or BZ if any): - Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Created in wrong repository, should be in fork |
Reviewer's GuideConsolidates CI testing into a single generalized GitHub Actions workflow that runs the Ansible SSH role tests across multiple container distributions (including new Alpine and Ubuntu 26 support), while aligning test expectations, role templates, and vars with the behavior of those distributions and adding a CodeRabbit configuration file. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The Alpine default
__ssh_defaults.Includepoints to/etc/ssh/ssh_config.d/*.conf, but the Alpine assertion intests/tests_no_skip_defaults.ymlexpectsInclude /etc/ssh/ssh_config.d/without the glob; consider aligning these paths so the defaults and tests reflect the same behavior. - The new CI workflow uses
Jakuje/check-ansible-action@main; consider pinning this action to a specific tag or commit SHA to avoid unexpected behavior from upstream changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Alpine default `__ssh_defaults.Include` points to `/etc/ssh/ssh_config.d/*.conf`, but the Alpine assertion in `tests/tests_no_skip_defaults.yml` expects `Include /etc/ssh/ssh_config.d/` without the glob; consider aligning these paths so the defaults and tests reflect the same behavior.
- The new CI workflow uses `Jakuje/check-ansible-action@main`; consider pinning this action to a specific tag or commit SHA to avoid unexpected behavior from upstream changes.
## Individual Comments
### Comment 1
<location path=".github/workflows/ansible-check.yml" line_range="31" />
<code_context>
- runs-on: ubuntu-latest
- steps:
- - name: checkout PR
- uses: actions/checkout@v6
-
- - run: "sed -i -e 's/ansible.posix.//g' */*.yml */*/*.yml"
</code_context>
<issue_to_address>
**issue (bug_risk):** Pin actions/checkout to a stable major version instead of v6, which does not exist yet.
`actions/checkout` is only published up to `v4`, so `@v6` will cause this workflow to fail. Please change it to a supported major version (e.g. `actions/checkout@v4`) or pin to a specific commit SHA.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v6 |
There was a problem hiding this comment.
issue (bug_risk): Pin actions/checkout to a stable major version instead of v6, which does not exist yet.
actions/checkout is only published up to v4, so @v6 will cause this workflow to fail. Please change it to a supported major version (e.g. actions/checkout@v4) or pin to a specific commit SHA.
Enhancement: Use single GH action to test on container images
Reason: The fleet of GH actions testing against different container images was not maintainable.
Result: On this role side, all code is in one workflow file.
Issue Tracker Tickets (Jira or BZ if any): -
Summary by Sourcery
Unify Ansible CI into a single container-based workflow while extending role support and tests for Alpine and newer Ubuntu, and exposing additional ssh_config options.
New Features:
Bug Fixes:
Enhancements:
CI:
Tests:
Chores: