Enable nvme-mi-send/recv admin command support unconditionally and add Windows support - #3788
Open
brgoing wants to merge 2 commits into
Open
Conversation
nvme-mi-send and nvme-mi-recv just implement the in-band MI admin command calls. They don't rely on the rest of the out-of-band MI support, and dont need to be gated by MI_CONFIG. Remove MI_CONFIG condition, making nvme-mi-send/nvme-mi-recv always supported. Move libnvme_mi_status_to_string out of out-of-band MI headers into util next to similar libnvme_status_to_string. Signed-off-by: Broc Going <bgoing@micron.com>
MI send/receive commands are supported by the Windows driver on WinPE. Add win-ioctl routing of the MI send/receive to the appropriate Windows IOCTL if on WinPE. Signed-off-by: Broc Going <bgoing@micron.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the in-band nvme-mi-send / nvme-mi-recv CLI commands available regardless of CONFIG_MI (since they’re NVMe admin passthrough commands, not out-of-band MI transport), adds Windows (WinPE-only) passthrough support for those opcodes, and relocates the MI status string helper into the core libnvme utilities so it’s available without MI transport support.
Changes: