ocp: sanitize tainted ascii_id_length before memcpy - #3786
Open
bellis-ibm wants to merge 1 commit into
Open
Conversation
ascii_id_length is a __u8 field read from device-supplied telemetry data (pstring_buffer). Passing it directly as the memcpy size without bounds checking allows a corrupt or malicious value to write beyond the description buffer. Replace 'memcpy(desc, src, len + 1)' with an explicit copy of len bytes followed by a null terminator. Since ascii_id_length is __u8 (max 255) and all callers provide a 256-byte buffer, the copy and terminator always fit without needing an additional clamp. The same fix is applied consistently across all three string lookup functions: get_statistic_id_ascii_string(), get_event_id_ascii_string() and get_vu_event_id_ascii_string(). Fixes Coverity CIDs 557416, 557331, 557323 (TAINTED_SCALAR). Signed-off-by: Brooke Ellis <Brooke.Ellis@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ascii_id_length is a __u8 field read from device-supplied telemetry
data (pstring_buffer). Passing it directly as the memcpy size without
bounds checking allows a corrupt or malicious value to write beyond
the description buffer.
Replace 'memcpy(desc, src, len + 1)' with an explicit copy of len
bytes followed by a null terminator. Since ascii_id_length is __u8
(max 255) and all callers provide a 256-byte buffer, the copy and
terminator always fit without needing an additional clamp.
The same fix is applied consistently across all three string lookup
functions: get_statistic_id_ascii_string(), get_event_id_ascii_string()
and get_vu_event_id_ascii_string().
Fixes Coverity CIDs 557416, 557331, 557323 (TAINTED_SCALAR).
Signed-off-by: Brooke Ellis Brooke.Ellis@ibm.com