sandisk: remove logically dead code in sndk_do_cap_telemetry_log - #3782
Open
sahmed-ibm wants to merge 1 commit into
Open
sandisk: remove logically dead code in sndk_do_cap_telemetry_log#3782sahmed-ibm wants to merge 1 commit into
sahmed-ibm wants to merge 1 commit into
Conversation
The function uses @host_gen and @ctrl_init flags to select which libnvme telemetry API to call. @host_gen is initialized to 1 and only ever set to 0 in the CONTROLLER branch, which also sets @ctrl_init to 1. Because the BOTH and invalid-type branches return early, the only code paths that reach the dispatch block are HOST (@ctrl_init=0, @host_gen=1) and CONTROLLER (@ctrl_init=1). The else branch calling libnvme_get_host_telemetry() is therefore unreachable - no defined telemetry type produces @ctrl_init=0 and @host_gen=0 simultaneously. Remove @host_gen and the dead libnvme_get_host_telemetry() branch. Replace the else if (@host_gen) guard with a plain else, making the two-way dispatch match the two reachable states. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function uses host_gen and ctrl_init flags to select which libnvme telemetry API to call. host_gen is initialized to 1 and only ever set to 0 in the CONTROLLER branch, which also sets ctrl_init to 1.
Because the BOTH and invalid-type branches return early, the only code paths that reach the dispatch block are HOST (ctrl_init=0, host_gen=1) and CONTROLLER (ctrl_init=1). The else branch calling libnvme_get_host_telemetry() is therefore unreachable - no defined telemetry type produces ctrl_init=0 and host_gen=0 simultaneously.
Remove host_gen and the dead libnvme_get_host_telemetry() branch. Replace the else if (host_gen) guard with a plain else, making the two-way dispatch match the two reachable states.