TPT-4616: Honor cancelled retries and use go work for vet/build - #1027
Open
zliang-akamai wants to merge 1 commit into
Open
TPT-4616: Honor cancelled retries and use go work for vet/build#1027zliang-akamai wants to merge 1 commit into
zliang-akamai wants to merge 1 commit into
Conversation
zliang-akamai
requested review from
lgarber-akamai and
mawilk90
and removed request for
a team
August 18, 2026 03:05
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the workspace build tooling and request retry behavior in linodego to better support the repository’s multi-module go.work layout and to respect context cancellation during retry backoff.
Changes:
- Switch
make vetandmake buildto usego vet work/go build workfor whole-workspace validation. - Update
Client.doRequestretry backoff to return early when the provided context is canceled. - Fix an unkeyed struct literal in a VPC subnet unit test (flagged by workspace vetting).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Makefile |
Moves vet/build to workspace-wide go ... work commands. |
client.go |
Makes retry wait context-aware (cancellation interrupts backoff). |
test/unit/vpc_subnets_test.go |
Keys the IPv6 create option field (Range) to satisfy vet. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
make vet/make buildto Go 1.25go vet work/go build workso the 3-module workspace is checked in one command.tidystays per-module.doRequestretry waits, and key the IPv6 create-option field thatgo vet workflagged.✔️ How to Test