Skip to content

TPT-4616: Honor cancelled retries and use go work for vet/build - #1027

Open
zliang-akamai wants to merge 1 commit into
mainfrom
zhiwei/tpt-4616-retry-ctx-go-work
Open

TPT-4616: Honor cancelled retries and use go work for vet/build#1027
zliang-akamai wants to merge 1 commit into
mainfrom
zhiwei/tpt-4616-retry-ctx-go-work

Conversation

@zliang-akamai

Copy link
Copy Markdown
Member

📝 Description

  • Switch make vet/make build to Go 1.25 go vet work / go build work so the 3-module workspace is checked in one command. tidy stays per-module.
  • Honor request cancellation during doRequest retry waits, and key the IPv6 create-option field that go vet work flagged.

✔️ How to Test

go vet work
go build work
make TEST_ARGS="-run TestDoRequest" test-unit

Copilot AI lite review requested due to automatic review settings August 18, 2026 03:05
@zliang-akamai zliang-akamai added the bugfix for any bug fixes in the changelog. label Aug 18, 2026
@zliang-akamai
zliang-akamai requested review from a team as code owners August 18, 2026 03:05
@zliang-akamai
zliang-akamai requested review from lgarber-akamai and mawilk90 and removed request for a team August 18, 2026 03:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workspace build tooling and request retry behavior in linodego to better support the repository’s multi-module go.work layout and to respect context cancellation during retry backoff.

Changes:

  • Switch make vet and make build to use go vet work / go build work for whole-workspace validation.
  • Update Client.doRequest retry backoff to return early when the provided context is canceled.
  • Fix an unkeyed struct literal in a VPC subnet unit test (flagged by workspace vetting).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
Makefile Moves vet/build to workspace-wide go ... work commands.
client.go Makes retry wait context-aware (cancellation interrupts backoff).
test/unit/vpc_subnets_test.go Keys the IPv6 create option field (Range) to satisfy vet.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread client.go
Comment on lines +625 to +629
select {
case <-ctx.Done():
return ctx.Err()
case <-time.After(waitTime):
}
Comment thread client.go
Comment on lines +625 to +629
select {
case <-ctx.Done():
return ctx.Err()
case <-time.After(waitTime):
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix for any bug fixes in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants