feat: path /secret auth + forwardedClientId + WS event metrics - #20
Open
snowkide wants to merge 5 commits into
Open
feat: path /secret auth + forwardedClientId + WS event metrics#20snowkide wants to merge 5 commits into
snowkide wants to merge 5 commits into
Conversation
Add AuthTypeForwardedClientId so a trusted gateway-injected X-Client-Id (Envoy apiKeyAuth.forwardClientIDHeader) becomes User.Id for per-client Prometheus labels. Emit erpc_ws_subscription_events_total (and dropped) on client notification write/overflow for third-party RPC observability. Co-authored-by: Cursor <cursoragent@cursor.com>
xray — see through AI slop with deterministic architecture PR diff reviews |
Use Network.Label() (alias when set) on ws_subscription_events_* so metrics match HTTP counters without a PromQL chain-id map. Co-authored-by: Cursor <cursoragent@cursor.com>
…dge Lua Domain-aliased hosts can keep a single path segment as the secret so clients use https://host/<KEY> without Envoy Lua/WASM path extractors. Co-authored-by: Cursor <cursoragent@cursor.com>
Reject empty secrets, require secret.id, cover path reserved segments, and dedupe subscription event counter increments. Co-authored-by: Cursor <cursoragent@cursor.com>
CLL rpc_ws_event_count_total must count JSON-RPC calls over WebSocket, not subscription push notifications. Mark WS ingress on NormalizedRequest and expose transport on erpc_network_request_received_total. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
Follow-up: transport label for CLL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forwardedClientIdstrategy for gateway-injectedX-Client-Id(Envoy apiKeyAuth mode)./<secret>andapikeyquery/header aliases remain available but CLL.comuses Envoy?apikey=+ forwardedClientId.Test plan
go test ./auth/