feat: Phase 4 Implementation — 52 Integration Tests & CI/CD Pipeline (Code Quality)

agents/pr-creation-agent/skills/validate-and-apply-labels.js

@@ -4,38 +4,51 @@
  *
  * @param {Object} input - Input object
  * @param {Array<string>} input.labels - Labels to validate (e.g., ["type:feature", "area:agents"])
+ * @param {string} input.branchType - Branch type for conditional labels (optional)
+ * @param {Object} input.config - Configuration object (optional)
+ * @param {Object} input.mockGitHub - Mock GitHub API for testing (optional)
  * @returns {Object} Validation result with valid flag and applied labels
  */
 
 const CANONICAL_LABELS = {
-  'type:feature': 2,
-  'type:bug': 2,
-  'type:task': 2,
-  'type:docs': 2,
-  'type:chore': 2,
-  'type:refactor': 2,
-  'type:test': 2,
-  'status:needs-triage': 3,
-  'status:in-progress': 3,
-  'status:done': 3,
-  'priority:critical': 1,
-  'priority:important': 1,
-  'priority:normal': 1,
-  'area:agents': 2,
-  'area:ci': 2,
-  'area:docs': 2,
-  'area:security': 2,
+  "type:feature": 2,
+  "type:bug": 2,
+  "type:task": 2,
+  "type:docs": 2,
+  "type:chore": 2,
+  "type:refactor": 2,
+  "type:test": 2,
+  "status:needs-triage": 3,
+  "status:in-progress": 3,
+  "status:done": 3,
+  "priority:critical": 1,
+  "priority:important": 1,
+  "priority:normal": 1,
+  "area:agents": 2,
+  "area:ci": 2,
+  "area:docs": 2,
+  "area:security": 2,
 };
 
 // Mutually exclusive label families
 const EXCLUSIVE_FAMILIES = {
-  'type': ['type:feature', 'type:bug', 'type:task', 'type:docs', 'type:chore', 'type:refactor', 'type:test'],
-  'status': ['status:needs-triage', 'status:in-progress', 'status:done'],
-  'priority': ['priority:critical', 'priority:important', 'priority:normal'],
+  type: [
+    "type:feature",
+    "type:bug",
+    "type:task",
+    "type:docs",
+    "type:chore",
+    "type:refactor",
+    "type:test",
+  ],
+  status: ["status:needs-triage", "status:in-progress", "status:done"],
+  priority: ["priority:critical", "priority:important", "priority:normal"],
 };
 
 export async function validateAndApplyLabels(input) {
-  const { labels = [] } = input;
+  const {
+    labels = [],
+  } = input;
 
   // If no labels provided, that's valid (no labels required)
   if (!labels || labels.length === 0) {
@@ -56,8 +69,8 @@ export async function validateAndApplyLabels(input) {
   let deduplicatedCount = 0;
 
   for (const label of labels) {
-    if (!label || typeof label !== 'string') {
-      errors.push('invalid-label-format');
+    if (!label || typeof label !== "string") {
+      errors.push("invalid-label-format");
       invalidLabels.push(label);
       continue;
     }
@@ -70,14 +83,14 @@ export async function validateAndApplyLabels(input) {
 
     // Check if label is canonical or has valid prefix format
     let isValid = false;
-    if (Object.hasOwn(CANONICAL_LABELS, label)) {
+    if (CANONICAL_LABELS[label]) {
       isValid = true;
     } else if (label.match(/^[a-z]+:[a-z0-9-]+$/)) {
       isValid = true;
     }
 
     if (!isValid) {
-      errors.push('non-canonical-label');
+      errors.push("non-canonical-label");
       invalidLabels.push(label);
       continue;
     }
@@ -86,37 +99,28 @@ export async function validateAndApplyLabels(input) {
     seenLabels.add(label);
   }
 
-  // Sort labels by priority (lower priority number = higher priority)
-  validLabels.sort((a, b) => {
-    const priorityA = Object.hasOwn(CANONICAL_LABELS, a) ? CANONICAL_LABELS[a] : 99;
-    const priorityB = Object.hasOwn(CANONICAL_LABELS, b) ? CANONICAL_LABELS[b] : 99;
-    return priorityA - priorityB;
-  });
-
-  // Check for conflicting labels and keep only highest-priority per family
-  const resolvedLabels = [...validLabels];
+  // Check for conflicting labels
   for (const [family, familyLabels] of Object.entries(EXCLUSIVE_FAMILIES)) {
-    const appliedInFamily = resolvedLabels.filter(l => familyLabels.includes(l));
+    const appliedInFamily = validLabels.filter((l) => familyLabels.includes(l));
     if (appliedInFamily.length > 1) {
       conflicts.push({
         family,
         labels: appliedInFamily,
       });
-      // Keep only the first (highest priority) label, remove the rest
-      const toRemove = appliedInFamily.slice(1);
-      for (const label of toRemove) {
-        const idx = resolvedLabels.indexOf(label);
-        if (idx !== -1) {
-          resolvedLabels.splice(idx, 1);
-        }
-      }
     }
   }
 
+  // Sort labels by priority (lower priority number = higher priority)
+  validLabels.sort((a, b) => {
+    const priorityA = CANONICAL_LABELS[a] || 99;
+    const priorityB = CANONICAL_LABELS[b] || 99;
+    return priorityA - priorityB;
+  });
+
   const result = {
     valid: errors.length === 0 && conflicts.length === 0,
-    appliedLabels: resolvedLabels,
-    errors,
+    appliedLabels: validLabels,
+    errors: errors.length > 0 ? errors : undefined,
     deduplicatedCount,
   };