Skip to content

feat: Phase 4 Implementation — 52 Integration Tests & CI/CD Pipeline #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashleyshaw merged 12 commits into from
Aug 24, 2026
Merged

feat: Phase 4 Implementation — 52 Integration Tests & CI/CD Pipeline #2334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3ec1d53
feat: Phase 4 Implementation — 52 Integration Tests & CI/CD Pipeline
claude Aug 22, 2026
e72e495
fix: Remove unused imports and variable declarations in integration t…
claude Aug 22, 2026
c45a873
Fix label validation error codes and priorities for integration tests
claude Aug 22, 2026
182e559
fix: Update error recovery and performance edge case tests to match d…
claude Aug 22, 2026
5ec64b9
style: Apply ESLint formatting fixes to code files
claude Aug 22, 2026
8962435
fix: Address CodeRabbit feedback - remove unused parameters and condi…
claude Aug 24, 2026
f0676a3
fix: Address CodeRabbit findings on branch validation and error handling
claude Aug 24, 2026
478dd96
style: Apply ESLint formatting fixes to integration tests and skills
claude Aug 24, 2026
5033701
fix: Remove unused imports from error-recovery-workflows test
claude Aug 24, 2026
7dca3d2
fix: Remove all unused variables and imports to pass ESLint no-warnin…
claude Aug 24, 2026
c970f26
Fix functional correctness issues in PR creation agent skills
claude Aug 24, 2026
cb8b21d
Update tests to match actual function implementations
claude Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 51 additions & 49 deletions .github/scripts/workflows/__tests__/metrics-collection-orchestrator.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
* Metrics Collection Orchestrator Tests
*/

const fs = require('fs');
const path = require('path');
const { MetricsCollectionOrchestrator } = require('../metrics-collection-orchestrator');
const fs = require("fs");
const path = require("path");
const {
MetricsCollectionOrchestrator,
} = require("../metrics-collection-orchestrator");

describe('MetricsCollectionOrchestrator', () => {
describe("MetricsCollectionOrchestrator", () => {
let orchestrator;
let configPath;
let testConfig;
Expand All @@ -15,9 +17,9 @@ describe('MetricsCollectionOrchestrator', () => {
// Create test configuration
testConfig = {
schedule: {
cron: '0 2 * * *',
timezone: 'UTC',
description: 'Daily metrics collection at 2 AM UTC',
cron: "0 2 * * *",
timezone: "UTC",
description: "Daily metrics collection at 2 AM UTC",
},
execution: {
parallelJobs: 1,
Expand All @@ -27,16 +29,16 @@ describe('MetricsCollectionOrchestrator', () => {
},
repositories: [
{
owner: 'lightspeedwp',
repo: '.github',
context: 'github-control-plane',
owner: "lightspeedwp",
repo: ".github",
context: "github-control-plane",
enabled: true,
},
],
storage: {
basePath: '.github/reports/metrics',
format: 'json',
timestampFormat: 'ISO8601',
basePath: ".github/reports/metrics",
format: "json",
timestampFormat: "ISO8601",
retention: {
days: 365,
maxFiles: 366,
Expand All @@ -45,17 +47,17 @@ describe('MetricsCollectionOrchestrator', () => {
notifications: {
onFailure: true,
onSuccess: false,
channels: ['github-issues'],
channels: ["github-issues"],
},
logging: {
level: 'info',
level: "info",
verbose: false,
outputPath: '.github/reports/metrics/logs',
outputPath: ".github/reports/metrics/logs",
},
};

// Write test configuration to temporary file
configPath = path.join(__dirname, 'test-metrics-config.json');
configPath = path.join(__dirname, "test-metrics-config.json");
fs.writeFileSync(configPath, JSON.stringify(testConfig, null, 2));
});

Expand All @@ -66,40 +68,40 @@ describe('MetricsCollectionOrchestrator', () => {
}
});

test('should load configuration successfully', () => {
test("should load configuration successfully", () => {
orchestrator = new MetricsCollectionOrchestrator(configPath);
expect(orchestrator.config).toBeDefined();
expect(orchestrator.config.repositories).toHaveLength(1);
expect(orchestrator.config.schedule.cron).toBe('0 2 * * *');
expect(orchestrator.config.schedule.cron).toBe("0 2 * * *");
});

test('should throw error when configuration file not found', () => {
const invalidPath = path.join(__dirname, 'nonexistent-config.json');
test("should throw error when configuration file not found", () => {
const invalidPath = path.join(__dirname, "nonexistent-config.json");
expect(() => {
new MetricsCollectionOrchestrator(invalidPath);
}).toThrow('Configuration file not found');
}).toThrow("Configuration file not found");
});

test('should throw error when repositories array is empty', () => {
test("should throw error when repositories array is empty", () => {
testConfig.repositories = [];
fs.writeFileSync(configPath, JSON.stringify(testConfig, null, 2));

expect(() => {
new MetricsCollectionOrchestrator(configPath);
}).toThrow('No repositories configured');
}).toThrow("No repositories configured");
});

test('should initialize storage and analyzers', () => {
test("should initialize storage and analyzers", () => {
orchestrator = new MetricsCollectionOrchestrator(configPath);
expect(orchestrator.storage).toBeDefined();
expect(orchestrator.trendAnalyzer).toBeDefined();
expect(orchestrator.anomalyDetector).toBeDefined();
});

test('should handle disabled repositories', async () => {
test("should handle disabled repositories", async () => {
testConfig.repositories = [
{ owner: 'org', repo: 'repo1', context: 'test', enabled: true },
{ owner: 'org', repo: 'repo2', context: 'test', enabled: false },
{ owner: "org", repo: "repo1", context: "test", enabled: true },
{ owner: "org", repo: "repo2", context: "test", enabled: false },
];
fs.writeFileSync(configPath, JSON.stringify(testConfig, null, 2));

Expand All @@ -111,15 +113,15 @@ describe('MetricsCollectionOrchestrator', () => {
expect(orchestrator.config.repositories).toHaveLength(2);
});

test('should generate summary with correct structure', async () => {
test("should generate summary with correct structure", async () => {
orchestrator = new MetricsCollectionOrchestrator(configPath);
orchestrator.startTime = Date.now();

// Add mock results
orchestrator.results = [
{
repository: 'lightspeedwp/.github',
status: 'success',
repository: "lightspeedwp/.github",
status: "success",
metricsCount: 15,
timestamp: new Date().toISOString(),
collectionTime: 2500,
Expand All @@ -139,14 +141,14 @@ describe('MetricsCollectionOrchestrator', () => {
expect(summary.results).toHaveLength(1);
});

test('should handle mixed success and error results', async () => {
test("should handle mixed success and error results", async () => {
orchestrator = new MetricsCollectionOrchestrator(configPath);
orchestrator.startTime = Date.now();

orchestrator.results = [
{
repository: 'lightspeedwp/.github',
status: 'success',
repository: "lightspeedwp/.github",
status: "success",
metricsCount: 15,
timestamp: new Date().toISOString(),
collectionTime: 2500,
Expand All @@ -157,9 +159,9 @@ describe('MetricsCollectionOrchestrator', () => {

orchestrator.errors = [
{
repository: 'lightspeedwp/plugin',
status: 'error',
error: 'GitHub API rate limit exceeded',
repository: "lightspeedwp/plugin",
status: "error",
error: "GitHub API rate limit exceeded",
timestamp: new Date().toISOString(),
},
];
Expand All @@ -169,17 +171,17 @@ describe('MetricsCollectionOrchestrator', () => {
expect(summary.execution.repositories.total).toBe(2);
expect(summary.execution.repositories.successful).toBe(1);
expect(summary.execution.repositories.failed).toBe(1);
expect(summary.execution.repositories.percentage).toBe('50.00');
expect(summary.execution.repositories.percentage).toBe("50.00");
});

test('should save summary report to disk', async () => {
test("should save summary report to disk", async () => {
orchestrator = new MetricsCollectionOrchestrator(configPath);
orchestrator.startTime = Date.now();

orchestrator.results = [
{
repository: 'lightspeedwp/.github',
status: 'success',
repository: "lightspeedwp/.github",
status: "success",
metricsCount: 15,
timestamp: new Date().toISOString(),
collectionTime: 2500,
Expand All @@ -192,12 +194,12 @@ describe('MetricsCollectionOrchestrator', () => {

// Verify summary file exists
const expectedPath = path.join(
'.github/reports/metrics',
`collection-summary-${new Date().toISOString().split('T')[0]}.json`
".github/reports/metrics",
`collection-summary-${new Date().toISOString().split("T")[0]}.json`,
);

if (fs.existsSync(expectedPath)) {
const savedSummary = JSON.parse(fs.readFileSync(expectedPath, 'utf8'));
const savedSummary = JSON.parse(fs.readFileSync(expectedPath, "utf8"));
expect(savedSummary.timestamp).toBeDefined();
expect(savedSummary.results).toHaveLength(1);

Expand All @@ -206,7 +208,7 @@ describe('MetricsCollectionOrchestrator', () => {
}
});

test('should track collection duration', async () => {
test("should track collection duration", async () => {
orchestrator = new MetricsCollectionOrchestrator(configPath);
const startTime = Date.now();
orchestrator.startTime = startTime;
Expand All @@ -216,8 +218,8 @@ describe('MetricsCollectionOrchestrator', () => {

orchestrator.results = [
{
repository: 'lightspeedwp/.github',
status: 'success',
repository: "lightspeedwp/.github",
status: "success",
metricsCount: 15,
timestamp: new Date().toISOString(),
collectionTime: 2500,
Expand All @@ -232,7 +234,7 @@ describe('MetricsCollectionOrchestrator', () => {
expect(summary.execution.duration).toBeGreaterThan(0);
});

test('should handle parallel vs sequential execution configuration', () => {
test("should handle parallel vs sequential execution configuration", () => {
testConfig.execution.parallelJobs = 4;
fs.writeFileSync(configPath, JSON.stringify(testConfig, null, 2));

Expand All @@ -241,7 +243,7 @@ describe('MetricsCollectionOrchestrator', () => {
expect(orchestrator.config.execution.parallelJobs).toBe(4);
});

test('should validate configuration structure', () => {
test("should validate configuration structure", () => {
orchestrator = new MetricsCollectionOrchestrator(configPath);

expect(orchestrator.config.schedule).toBeDefined();
Expand Down
Loading
Loading