Skip to content

LCORE-: Resolved circular dependencies - #2280

Open
asimurka wants to merge 1 commit into
lightspeed-core:feature/upgrade-ogx-to-1.0.2from
asimurka:feature/upgrade-ogx-to-1.0.2
Open

LCORE-: Resolved circular dependencies#2280
asimurka wants to merge 1 commit into
lightspeed-core:feature/upgrade-ogx-to-1.0.2from
asimurka:feature/upgrade-ogx-to-1.0.2

Conversation

@asimurka

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@asimurka
asimurka marked this pull request as draft July 29, 2026 08:28
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0f6fab59-f4b4-4452-98e5-6b0cebea4075

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asimurka asimurka changed the title Uncomment e2e tests LCORE-: Uncomment e2e tests Jul 29, 2026
@asimurka
asimurka force-pushed the feature/upgrade-ogx-to-1.0.2 branch from 840769d to d976d8f Compare July 29, 2026 08:42
Move append_turn_to_conversation into utils.conversations so capabilities
no longer depend on utils.shields at import time.

Co-authored-by: Cursor <cursoragent@cursor.com>
@asimurka
asimurka force-pushed the feature/upgrade-ogx-to-1.0.2 branch from d9ee142 to 3068b80 Compare July 29, 2026 09:34
@asimurka asimurka changed the title LCORE-: Uncomment e2e tests LCORE-: Resolved circular dependencies Jul 29, 2026
@asimurka
asimurka marked this pull request as ready for review July 29, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant