Add ID_TYPE and ID_NUMBER to CustomerInfoFieldName#547
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
✱ Stainless preview builds for gridThis PR will update the cli csharp go kotlin openapi php python ruby typescript ✅ grid-ruby studio · code
|
Greptile SummaryAdds
Confidence Score: 5/5Safe to merge — adds two enum values to a string schema with no breaking changes to existing consumers. The change is purely additive: two new enum values in an OpenAPI string schema. The source file was edited in the correct location, both generated bundles are consistent with one another, naming follows the existing convention, and there is no drift in the regenerated files beyond the intended delta. No files require special attention.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/customers/CustomerInfoFieldName.yaml | Source schema file — adds ID_TYPE and ID_NUMBER to the enum; correct place to make the edit per CLAUDE.md conventions. |
| openapi.yaml | Generated bundle — mirrors the source change with the same two enum values, consistent with a make build regeneration. |
| mintlify/openapi.yaml | Mintlify-targeted generated bundle — identical delta to openapi.yaml, consistent with a single build pass. |
Sequence Diagram
sequenceDiagram
participant Platform
participant GridAPI as Grid API (quote create)
participant Validator as Field Validator
participant Sparkcore
Platform->>GridAPI: "POST /quotes { senderCustomerInfo: { ID_TYPE, ID_NUMBER } }"
GridAPI->>Validator: Validate CustomerInfoFieldName enum
Note over Validator: Now accepts ID_TYPE and ID_NUMBER
Validator-->>GridAPI: Valid
GridAPI->>Sparkcore: Forward quote request
Sparkcore-->>GridAPI: Quote response
GridAPI-->>Platform: Quote created
Reviews (1): Last reviewed commit: "Add ID_TYPE and ID_NUMBER to CustomerInf..." | Re-trigger Greptile
Summary
ID_TYPEandID_NUMBERto theCustomerInfoFieldNameenum so platforms can pass sender identity documents insenderCustomerInfoon quote create.Test plan
openapi.yamlre-generated cleanly with only the two added enum values (no unrelated drift)update_schema.shin webdev/grid-api/ to regenerate Pydantic models; verify the regeneratedcustomer_info_field_name.pyincludesID_TYPE = 'ID_TYPE'andID_NUMBER = 'ID_NUMBER'