chore: Sync account schemas#543
Closed
lightspark-copybara[bot] wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
the
breaking-change
Contributor
|
Contributor
✱ Stainless preview builds for gridThis PR will update the cli csharp go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-openapi studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-typescript studio · code · diff
✅ grid-python studio · code · diff
✅ grid-csharp studio · code · diff
✅ grid-go studio · code · diff
✅ grid-php studio · code · diff
✅ grid-cli studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Contributor
Greptile SummaryThis PR syncs account schema definitions from sparkcore, adding
Confidence Score: 5/5Safe to merge — changes are additive schema documentation updates synced from sparkcore with no logic changes. All five currency schemas that add No files require special attention; all changes are mechanical schema syncs.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/UsdAccountInfoBase.yaml | Adds optional accountHolderName (string) and bankAddress (allOf $ref Address) fields to USD account info; both are non-required, non-breaking additions. |
| openapi/components/schemas/common/BdtAccountInfoBase.yaml | Adds bankName to required array and properties; updates description to reflect bankName is now needed for both BANK_TRANSFER and MOBILE_MONEY rails. |
| openapi/components/schemas/common/PkrAccountInfoBase.yaml | Moves bankName to the top of properties (after accountType) and adds it to the required array; updates BANK_TRANSFER description to include bankName; example reordered accordingly. |
| openapi.yaml | Bundled OpenAPI spec updated to reflect all schema changes: bankName required in BDT/EGP/GHS/COP/PKR, accountHolderName and bankAddress added to USD. |
| mintlify/openapi.yaml | Mintlify bundled spec updated with the same changes as openapi.yaml; appears to be an identical copy of the root bundled spec. |
Class Diagram
%%{init: {'theme': 'neutral'}}%%
classDiagram
class UsdAccountInfoBase {
+string accountType (required)
+string accountNumber (required)
+string routingNumber (required)
+string accountHolderName (NEW, optional)
+Address bankAddress (NEW, optional)
}
class BdtAccountInfoBase {
+string accountType (required)
+string bankName (NEW, required)
+string accountNumber
+string branchCode
+string swiftCode
+string phoneNumber
}
class EgpAccountInfoBase {
+string accountType (required)
+string bankName (NEW, required)
+string iban
+string phoneNumber
}
class GhsAccountInfoBase {
+string accountType (required)
+string bankName (NEW, required)
+string accountNumber
+string phoneNumber
}
class CopAccountInfoBase {
+string accountType (required)
+string bankName (NEW, required)
+string accountNumber
+string bankAccountType
+string phoneNumber
}
class PkrAccountInfoBase {
+string accountType (required)
+string bankName (NOW required, was optional)
+string accountNumber
+string iban
+string phoneNumber
}
class Address {
+string line1 (required)
+string postalCode (required)
+string country (required)
+string line2
+string city
+string state
}
UsdAccountInfoBase --> Address : bankAddress
Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile
Contributor
Author
|
Superseded by #545 |
lightspark-copybara
Bot
deleted the
auto/sync-grid-schemas-20260603-170821
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.