Add rust Dockerfile#80
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tankyleo! This PR has been waiting for your review. |
tankyleo
left a comment
There was a problem hiding this comment.
Thanks ! can you make this one commit / remove the merge commit in the current PR ?
tankyleo
left a comment
There was a problem hiding this comment.
As mentioned above, let's bring back ca-certificates for HTTPS requests.
Also squash all the commits into a single one.
fcec5ff to
2336a2d
Compare
Isn't that possible to do when merging by |
I need to ACK the exact commit that will get merged, should be quite doable on your side no ? |
|
@frnandu making sure you see this message above thanks for squashing if you can |
2336a2d to
7f34829
Compare
|
Squashed, thanks! |
tankyleo
left a comment
There was a problem hiding this comment.
Thanks tested on my machine looks good.
One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.
7f34829 to
2bbc54c
Compare
done |
|
ping? |
2bbc54c to
834b6b9
Compare
|
@frnandu I cleaned up the branch, used tnull thanks for taking a look I can't merge since I'm the last pusher. |
| # Copy default configuration file | ||
| COPY server/vss-server-config.toml /app/vss-server-config.toml | ||
|
|
||
| EXPOSE 8080 |
There was a problem hiding this comment.
It seems by default this will only bind to localhost. Do we need to set VSS_BIND_ADDRESS to make this work outside of docker/reachable by other docker containers?
- [P2] Use container-reachable network defaults — /home/tnull/workspace/vss-server/rust/Dockerfile:40-40
When the image is run with its default CMD, e.g. docker run -p 8080:8080 ..., /app/vss-server-config.toml still binds VSS to 127.0.0.1 and points PostgreSQL at 127.0.0.1. Inside Docker those are container-loopback addresses, so the published port cannot reach the server and Postgres on
another container/host is unreachable unless users override both env vars. Consider shipping a Docker-specific config or setting Docker defaults such as VSS_BIND_ADDRESS=0.0.0.0:8080 and a network-reachable Postgres address.
fixes #74