Add Address Library IDs for planet survey / knowledge / star-map scan - #42
Closed
pjmagee wants to merge 2 commits into
Closed
Add Address Library IDs for planet survey / knowledge / star-map scan#42pjmagee wants to merge 2 commits into
pjmagee wants to merge 2 commits into
Conversation
… paths IDs verified against Starfield 1.16.236-1.16.244 versionlibs and used in production by the Complete Planet Survey SFSE plugin. ID-only addition - no speculative class layouts (layouts remain documented at call sites until dedicated headers land). Includes: BSGalaxy knowledge manager singleton, knowledge DB lookup, PlayerKnowledge slot writers, survey notify/aggregator/scan-complete, BGSPlanet trait/progress/scan-level writers, star-map panel handlers, misc-stat table globals, scannable canonical resolve, BSTArray u32 grow, TESForm all-forms map holder. Does not fill StarMapMenu_* GetEventSource zeros: id 142196 is not a TLS-style GetEventSource and needs separate identification.
…r APIs Addresses pjmagee/commonlibsf issues #1, #2, and #3 on the upstream-fixes branch. - IDs for Manager singleton/SetCurrentPlanet/ResolvePlanetFromRef, ScannableComponent outline/scan APIs, knowledge DB iterate helpers, PlayerKnowledge slot writers - Headers: BGSPlanetManager.h, BSGalaxyKnowledge.h, ScannableComponent.h - Verified Address Library IDs non-zero on 1.16.244; commonlibsf xmake build green Layouts are partial where full sizeof is unknown; static_assert only on documented offsets (Manager+0x80, SpeciesScanSlot fields).
This was referenced Jul 18, 2026
Contributor
Author
|
Renaming fork branch upstream-fixes -> upstream-contributions; reopening from the new branch name (same commits). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds verified Address Library IDs used by planet survey / PlayerKnowledge / star-map scan workflows (production-tested in Complete Planet Survey on Starfield 1.16.236-1.16.244).
ID-only PR (matches recent contributions such as book-event IDs): no speculative class layouts or offset structs.
Replaces #41 (same commits; fork branch is now
upstream-fixesfor the mod submodule workflow).Namespaces added / extended
BGSPlanetBSGalaxy::KnowledgeManagerBSComponentDB2BSTArrayMiscStatPlayerKnowledgeScannableSurveyStarMapTESFormExplicit non-goals
Test plan