linux: add setting to toggle media takeover - #748
Open
Loffah wants to merge 1 commit into
Open
Conversation
The app unconditionally force-connects to the AirPods and sends a disconnect request to the phone whenever any MPRIS player reports Playing. With multipoint AirPods this steals audio from the phone even when the desktop playback was unintentional (a notification sound, or a player stuck buffering still reports Playing). Add a 'Take Over Audio When Media Plays' switch in settings, persisted as media/takeoverEnabled, defaulting to true to keep the current behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Take Over Audio When Media Plays switch to the Linux app settings, controlling whether the app force-connects to the AirPods (and sends a disconnect request to the phone) when an MPRIS player starts playing.
Persisted as
media/takeoverEnabled, defaults to true so current behavior is unchanged for existing users.Why
handleMediaStateChangecurrently reacts to any MPRIS player reporting Playing, unconditionally. With multipoint AirPods this steals audio from the phone in cases the user did not intend:In those cases the AirPods get yanked away from the phone mid-listen. The feature itself is great; it just needs an off switch for people who share the pods between an active phone and desktop.
Testing
🤖 Generated with Claude Code