Skip to content

Monitor the space condition, defer reload while accessors held. #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Aug 8, 2026
Merged

Monitor the space condition, defer reload while accessors held. #1095

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7470383
Defer reload while accessors held.
evoskuil Aug 8, 2026
a5519fd
Monitor the space condition, not suspension.
evoskuil Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/chasers/chaser_storage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ void chaser_storage::handle_timer(const code& ec) NOEXCEPT
return;
}

// Network is resumed or store is failed, cancel monitoring.
if (!suspended() || archive().is_fault())
// Store is failed or the condition is clear, cancel monitoring.
if (archive().is_fault() || !to_bool(archive().get_space()))
return;

// There are often multiple events, each resetting the timer.
Expand All @@ -152,6 +152,15 @@ void chaser_storage::do_reload() NOEXCEPT
<< "(" << full_node::store::tables.at(table) << ")");
}))
{
// A locked reload is a wait (in-flight accessors), not a failure:
// retry on the timer. All other store errors are terminal.
if (ec == database::error::reload_locked)
{
LOGN("Reload deferred by in-flight accessors.");
disk_timer_->start(BIND(handle_timer, _1));
return;
}

LOGF("Reload from disk full condition failed, " << ec.message());
}
else
Expand Down
Loading