Prevents circumscribing other nodes in the triangulation#4483
Open
ConnorOuellette wants to merge 3 commits into
Open
Prevents circumscribing other nodes in the triangulation#4483ConnorOuellette wants to merge 3 commits into
ConnorOuellette wants to merge 3 commits into
Conversation
roystgnr
requested changes
Jun 15, 2026
roystgnr
left a comment
roystgnr
left a comment
Member
There was a problem hiding this comment.
I believe the actual change buried in here is a necessary bugfix, but we can't bury it in a thousand lines of clang-format changes
Author
|
Should now be much more coherent and reasonable |
roystgnr
approved these changes
Jun 15, 2026
roystgnr
left a comment
roystgnr
left a comment
Member
There was a problem hiding this comment.
Looks perfect. We should "Squash and Merge" rather than the usual, though, to keep the history clean.
Assuming CI passes, that is. It's entirely possible that we golded something downstream that was affected by the same bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swapped ordering of code blocks to prevent early return that caused the issue. Resolves bug discovered during MOOSE dual_mesh development.