Skip to content

TRI7 center node adjustment and TRI6/7 degeneracy checks after midpoint relocation#4481

Draft
miaoyinb wants to merge 2 commits into
libMesh:develfrom
miaoyinb:QuadraticElemImprovement
Draft

TRI7 center node adjustment and TRI6/7 degeneracy checks after midpoint relocation#4481
miaoyinb wants to merge 2 commits into
libMesh:develfrom
miaoyinb:QuadraticElemImprovement

Conversation

@miaoyinb

Copy link
Copy Markdown
Contributor

closes #4480

@miaoyinb

Copy link
Copy Markdown
Contributor Author

As this PR moves TRI7 center node, MOOSE's meshgenerators/xy_delaunay_generator.xydelaunay/quadratic_tri7 test needs to be regolded.

@moosebuild

moosebuild commented Jun 12, 2026

Copy link
Copy Markdown

Job Coverage, step Generate coverage on 4659afd wanted to post the following:

Coverage

862243 #4481 4659af
Total Total +/- New
Rate 65.60% 64.84% -0.76% 100.00%
Hits 78626 77754 -872 58
Misses 41235 42165 +930 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@roystgnr

Copy link
Copy Markdown
Member

As a general rule "midpoint goes at the centroid" isn't always right, since you can do some clever things with boundary layers by using slightly-off-center higher order nodes in the grading, but in this context I think this is exactly the right thing to do.

If you don't want to create a big "have to get the submodule updated to regold" vs "can't merge the PR without breaking a ton of recipes" chicken-and-egg problem, the general way to do that is to add new behavior as an option before we change behavior by default. Default the new behavior to "off", then after MOOSE is updated turn it on there and regold, then change the default to "on".

@miaoyinb

Copy link
Copy Markdown
Contributor Author

Good point, I will make it optional.

@moosebuild

Copy link
Copy Markdown

Job Distributed make check sweep (odd) on 4659afd : invalidated by @miaoyinb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quadratic Triangulation Degeneracy After Midpoint Relocation

3 participants