Add bundled agent skill command#349
Merged
Merged
Conversation
Reviewer's GuideIntroduce an experimental File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
skillsInstallOptions.targetDir, prompting for scope fails entirely iflocalSkillsDircannot be resolved (e.g., not in a Git repo), even when the user might want a global install; consider making the local path optional in this case so that prompting still works and global-only installs are possible. findGitRootonly detects repositories where.gitis a directory; for worktrees or non-standard setups where.gitis a file, this will fail and break--localinstalls, so it may be worth extending this helper to handle.gitas a file pointing to the actual repo metadata.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `skillsInstallOptions.targetDir`, prompting for scope fails entirely if `localSkillsDir` cannot be resolved (e.g., not in a Git repo), even when the user might want a global install; consider making the local path optional in this case so that prompting still works and global-only installs are possible.
- `findGitRoot` only detects repositories where `.git` is a directory; for worktrees or non-standard setups where `.git` is a file, this will fail and break `--local` installs, so it may be worth extending this helper to handle `.git` as a file pointing to the actual repo metadata.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add experimental
lets self skillscommands to manage the bundled lets agent skill and document their usage.New Features:
lets self skillssubcommands to show, install, and update the bundled lets agent skill, including local/global scopes and custom paths.letsAgent Skill definition within the binary for installation into standard Agent Skills directories.Documentation:
letsskill, its installation locations, and usage, and link it from the config reference.lets self skillscommands and Agent Skills documentation.Tests:
lets self skillsshow, install (local/global), non-destructive installs, and update behaviors.