Fix CardExpander height to enable ScrollViewer functionality - #1747
Open
Just-Silver wants to merge 3 commits into
Open
Fix CardExpander height to enable ScrollViewer functionality#1747Just-Silver wants to merge 3 commits into
Just-Silver wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
The CardExpander template defines the content row as
Height="Auto"(line 117 inCardExpander.xaml), which causes the content area to grow unbounded regardless of available space. This prevents ScrollViewer from working — wrapping content in ScrollViewer has no effect because the parent Grid never constrains height.What is the new behavior?
CardExpander.xamlcontent row fromHeight="Auto"toHeight="*"Other information
Before: Content row uses
Height="Auto", content grows infinitely, ScrollViewer has no effect.After: Content row uses
Height="*", content is constrained to available space, ScrollViewer works correctly.