Lab6: EchoServer refactoring for testability + unit tests#49
Open
MinTins wants to merge 26 commits into
Open
Conversation
…nfrastructure from coverage
…ethods - UdpClientWrapper.Exit() now delegates to StopListening() (was identical copy) - TcpClientWrapper.SendMessageAsync(string) now delegates to SendMessageAsync(byte[]) (removed duplicated write+log logic) - NetSdrClient: extracted EnsureConnected() helper to remove 3 identical 'no active connection' guard blocks
- Added NetSdrArchTests project with NetArchTest.Rules - 4 architecture rules: Networking↛Messages, Messages↛Networking, NetworkingClasses implement interface, NetSdrClient in root namespace - BreakingRuleTest.cs: intentional failing test to demonstrate red CI (will be removed in next commit)
… for red CI demo)
- Removed BreakingRuleTest.cs (was intentionally failing for red CI demo) - All 4 architecture rules now pass: * Networking does not depend on Messages * Messages does not depend on Networking * All Networking classes implement interface * NetSdrClient resides in root namespace
…namespace Rule 3 was failing because UdpClientWrapper and IUdpClient are declared in the global namespace (no namespace keyword), not in NetSdrClientApp.Networking. Fixed Rule 3 to only check TcpClientWrapper implements ITcpClient, which correctly resides in NetSdrClientApp.Networking.
Refactoring: - Extracted ITcpListener interface to decouple EchoServer from real sockets - Added TcpListenerWrapper (production impl, ExcludeFromCodeCoverage) - Added namespace EchoTcpServer to all classes - Made HandleClientAsync internal (InternalsVisibleTo EchoServerTests) - Moved UdpTimedSender to separate file - Simplified Program.cs to composition root only Tests (EchoServerTests): - StartAsync_CallsListenerStart - StartAsync_ExitsLoop_OnObjectDisposedException - Stop_CallsListenerStop - Stop_CanBeCalledWithoutStart - HandleClientAsync_EchoesDataBack - HandleClientAsync_StopsOnCancellation - HandleClientAsync_ClosesClientOnCompletion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lab6: Безпечний рефакторинг EchoServer під тести
Автор: Флакей Роман (MinTins)
Що зроблено
Рефакторинг EchoServer
ITcpListenerінтерфейс — EchoServer більше не залежить від реальних сокетівTcpListenerWrapper(production реалізація, виключена з coverage)namespace EchoTcpServerдо всіх класівHandleClientAsyncзмінено зprivateнаinternal(доступний для тестів черезInternalsVisibleTo)UdpTimedSenderвиокремлено в окремий файлProgram.csспрощено до composition rootНові тести (EchoServerTests)
StartAsync_CallsListenerStartStartAsync_ExitsLoop_OnObjectDisposedExceptionStop_CallsListenerStopStop_CanBeCalledWithoutStartHandleClientAsync_EchoesDataBackHandleClientAsync_StopsOnCancellationHandleClientAsync_ClosesClientOnCompletionМетрики до/після