feat(spec): review findings that indict a source route back, never apply - #957
Open
leeovery wants to merge 2 commits into
Open
feat(spec): review findings that indict a source route back, never apply#957leeovery wants to merge 2 commits into
leeovery wants to merge 2 commits into
Conversation
The review loop's only verbs were apply, adjust, skip — all against the spec — so a finding revealing a source defect could land nowhere but the spec, and the discussion stayed wrong on disk. Two new finding categories (Source defect, Unsourced decision) route through resolve-source-incoherence.md instead of the finding gate, landing as Routed in the tracking file; the input agent gains the reverse fidelity check (spec content tracing to no source), the gap-analysis agent flags open-decision markers as Critical, and the finding surface refuses auto for gap findings — a question never auto-applies. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
At review time the defective content is already extracted — landing the correction in the source alone would leave the spec asserting what the record no longer does. The route branch now updates the affected spec content to match the corrected source before marking the finding Routed; the record settles it, so no gate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Idea 40:
process-review-findings.mdhad exactly three verbs — apply, adjust, skip — all against the spec. A finding revealing that the source is wrong had no route; the observed session could only patch the spec and leave the completed discussion asserting falsehoods. Separately, 16 undiscussed design decisions sat in the spec behind invented "Decision required" markers, shielded from review, and gap findings auto-applied orchestrator-authored content underfinding_gate_mode: auto.What
review-tracking-format.md):Source defectandUnsourced decision— never applied/adjusted/skipped, never rideauto; the orchestrator routes them throughresolve-source-incoherence.md(new Route Source-Lane Findings section inprocess-review-findings.md), resolution lands asRouted. A gap exit pauses the spec via the existing machinery; the in-progress tracking entry re-processes at next entry.render findingaccepts an optionalcategory;gaprenders its gate even underauto— a question never auto-applies. Unknown categories throw (routed categories reaching this surface is a caller bug). Tests added.Stacks on #955. Part 3 of the idea-40 stack.
🤖 Generated with Claude Code